1880078 - Previously opened container tabs are still shown in the Tabs/Firefox suggest section after a browser restart

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Ardelean Oana, Desktop QA [:oardelean]]

Notes

• Please refer to the following screen recording for more details.

Found in

• Firefox Nightly 124.0a1;

Affected versions

• Firefox Nightly 124.0a1;

Tested platforms

• Windows 10;
• Ubuntu 22;
• macOS 12;

Affected platforms

• Windows 10;
• Ubuntu 22;
• macOS 12;

Unaffected platforms

• N/A;

Preconditions

• browser.urlbar.switchTabs.searchAllContainers set to true

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Open a website in different container tabs(Personal, Work, Banking, Shopping).
3. Restart the browser.
4. Close all the container tabs.
5. Open a new regular tab and write the title of the previously opened website in step 2, or enter ‘Tabs’ mode in the Address Bar
6. Click on any of the Switch to Tab buttons.

Expected result

• There should not be any container tabs featured in the Address Bar.

Actual result

• Container tabs are still shown in the Address Bar and clicking the Switch to Tab button does nothing.

Regression range

• Not a regression.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

:oardelean, if you think that's a regression, could you try to find a regression range using for example mozregression?

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

It looks like the tab is registered at restore time, but then when it's closed without being first loaded, it's not unregistered. Visiting the tab before closing it unregisters normally.
It's likely a problem of suspended tabs.

Comment 3

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

Attachment: Bug 1880078 - A previously opened tab is shown in Address Bar after restarting the browser and closing the tab. r=jteow

Some consumer is passing in integer as expected, most pass a numeric string
that is the result of a getAttribute. This causes a mismatch as that id is used
as key in a Map.
While it would be possible to fix all the consumers, the mistake seems so
common and trivial, that is worth just adapting the API to accept both.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e594b8a45404
A previously opened tab is shown in Address Bar after restarting the browser and closing the tab. r=jteow

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/e594b8a45404

Comment 6

[Ardelean Oana, Desktop QA [:oardelean]]

Issue is verified as fixed on Firefox Nightly 125.0a1 on macOS 12, Windows 10 and Ubuntu 22.