1880105 - Improve the GC microbenchmark framework

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement, P5)

Description

[Jon Coppeard (:jonco)]

I wanted to use this framework to help visualise what was happening in bug 1873235. While doing so I made some improvements.

Comment 1

[Jon Coppeard (:jonco)]

Attachment: Bug 1880105 - Part 1: Fix loading the microbenchmark framework in other browsers r?sfink

Currently this doesn't load for me in Chrome or Safari because of different
async behaviour around loading modules.

The patch waits for dynamic imports to finish before accessing the tests in
onload().

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1880105 - Part 2: Use high DPI canvas for microbenchmark framework where available r?sfink

To make this look nicer we can use a high DPI canvas where available. Mostly
this involves scaling all the draw coordinates.

I did also make the canvas slightly smaller so that you can more easily see
both timing and memory information when both are displayed.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: Bug 1880105 - Part 3: Add malloc memory data to the heap size graph r?sfink

This also removes min memory sizes as these are usually always zero or very small

Comment 4

[Jon Coppeard (:jonco)]

Attachment: Bug 1880105 - Part 4: Associate form labels with input elements r?sfink

Comment 5

[Jon Coppeard (:jonco)]

Attachment: Bug 1880105 - Part 5: Fix assigning to change_garbagePerFrame method rather than calling it r?sfink

Comment 6

[Jon Coppeard (:jonco)]

Attachment: Bug 1880105 - Part 6: Improve formatting of size quantities r?sfink

This removes the decimal part of these numbers where possible, e.g. displaying
8K for 8192 bytes rather than 8.00K.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/287def1730a5
Part 1: Fix loading the microbenchmark framework in other browsers r=sfink DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/ff762c6165e3
Part 2: Use high DPI canvas for microbenchmark framework where available r=sfink DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/dd565811c677
Part 3: Add malloc memory data to the heap size graph r=sfink DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/bae152868933
Part 4: Associate form labels with input elements r=sfink DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/8fdf8a4ed06e
Part 5: Fix assigning to change_garbagePerFrame method rather than calling it r=sfink DONTBUILD
https://hg.mozilla.org/integration/autoland/rev/6e217087e030
Part 6: Improve formatting of size quantities r=sfink DONTBUILD

Comment 8

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/287def1730a5
https://hg.mozilla.org/mozilla-central/rev/ff762c6165e3
https://hg.mozilla.org/mozilla-central/rev/dd565811c677
https://hg.mozilla.org/mozilla-central/rev/bae152868933
https://hg.mozilla.org/mozilla-central/rev/8fdf8a4ed06e
https://hg.mozilla.org/mozilla-central/rev/6e217087e030