1880108 - Placeholders on the datetime widget ignore spoof English

Status: RESOLVED FIXED

(Toolkit :: UI Widgets, defect)

Description

[Pier Angelo Vendrame]

Steps to reproduce:

• set Firefox in a language different than en-US and enable RFP + spoof English
• open a page with a datetime widget (e.g., https://arkenfox.github.io/TZP/tests/applang.html)
• notice that the placeholder is using the en-US format, but the localized placeholders (e.g., mm / gg / aaaa instead of mm / dd / yyyy)

Comment 1

[Pier Angelo Vendrame]

Attachment: Bug 1880108 - Pass the locale list when constructing l10n in datetimebox. r=#reusable-components-reviewers,tgiles

The datetime input is inconsistent with other inputs when using spoof
English: its placeholder is not translated, unlike the default values
and texts of all the other inputs.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fab1526875d3
Pass the locale list when constructing l10n in datetimebox. r=reusable-components-reviewers,tgiles

Comment 3

[Noemi Erli[:noemi_erli]]

Backed out changeset fab1526875d3 (Bug 1880108) for causing failures in browser_caching_attributes.js

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&collapsedPushes=842382&selectedTaskRun=NrdDyObyROqNuM80uS8n6w.0&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=fab1526875d3ddfadbae0e0c6f305b4696fe62a6

Log: https://treeherder.mozilla.org/logviewer?job_id=448999171&repo=autoland&lineNumber=4504
browser-chrome: https://treeherder.mozilla.org/logviewer?job_id=448996825&repo=autoland&lineNumber=13133

Backout: https://hg.mozilla.org/integration/autoland/rev/81edde55cc8899af0acb636f545d91efcc6dc59c

Comment 4

[Pier Angelo Vendrame]

I can't reproduce these failures locally (but I'm on Linux, setting up a Firefox dev environment on a macOS machine would take me a while).
So, I tried to run another try build, but it doesn't contain the errors from the logs.

https://treeherder.mozilla.org/logviewer?job_id=448999171&repo=autoland&lineNumber=4504

This is a "Test timed out -", could it be due to something else?

https://treeherder.mozilla.org/logviewer?job_id=448996825&repo=autoland&lineNumber=13133

The root cause seems a missing datetimebox.ftl: https://treeherder.mozilla.org/logviewer?job_id=448999171&repo=autoland&lineNumber=4433
It says locale en, whereas I expected something like en-US instead.
I've tried to play a little bit with getWebExposedLocales(), but I always get en-US appended at the end (when using another language) or instead of a regional variant (e.g., in en-GB).
I don't think I know of to explain this failure.
Who could I redirect this NI to for some help?

Comment 5

[Pier Angelo Vendrame]

Is there anyway I could get this merged again?
I think the failed tests were false positives.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6d6b80ebc023
Pass the locale list when constructing l10n in datetimebox. r=reusable-components-reviewers,tgiles

Comment 7

[Cristian Tuns]

Backed out for causing multiple failures on OS X 10.15 WebRender. (Please check the: push with failures link)

• Backout link
• Push with failures

Comment 8

[Pier Angelo Vendrame]

Okay, it seems the macOS test uses en as a locale (I don't know why).
In the new revision I'm forcing en-US to be there as a fallback, in case the webExposedLocales do not include any locale with the proper translation.
Also, I gated the patch on RFP.

Comment 9

[Pier Angelo Vendrame]

Hi, I sent some changes because the tests found some problems with my previous patch (basically, en-US wasn't automatically appended as fallback language).
Could you please review the patch again? Thanks in advance!

Comment 10

[Tim Giles [:tgiles]]

Went ahead and reviewed the patch, changes look good to me. Queued up the patch in Lando as well. Hopefully it'll stick this time!

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a414b7e839e5
Pass the locale list when constructing l10n in datetimebox. r=reusable-components-reviewers,tgiles

Comment 12

[Thorin [:thorin]]

FYI: test is at https://arkenfox.github.io/TZP/tests/elementforms.html, no visuals - you should get the same hash (or in this specific case, the details measurements) on your machine (because it can vary across machines) in any app language with spoof_english

I think we should add a test - RFP + en-US detail width == RFP + ga-IE detail width

for example: the first measurement is width

en-US for me = "details": [66.75, 21.566665649414062, -3.6666717529296875, -1.1833343505859375],
ga-IE for me = "details": [98.73333740234375, 21.566665649414062, -5.4166717529296875, -1.1833343505859375],

Comment 13

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/a414b7e839e5