1880199 - Ensure pinned tabs expose their pinned state to the Accessibility API

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Anna Yeddi [:ayeddi]]

Pinned tabs do not expose their pinned state to the Accessibility API anymore.

Gecko supports pinned state in the XULTabAccessible, but since the pseudo-boolean tab strip attribute was changed to be a standard boolean, the a11y engine cannot confirm the pinned state.

Note: the issue affects all desktop platforms, but macOS does not have support for pinned state, so we may need to track it separately

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849904

:dao, since you are the author of the regressor, bug 1849904, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[James Teh [:Jamie]]

A11y should now check whether the attribute exists rather than checking for "true". But we should probably also have a browser test for this, since it regressed without anyone noticing.

Comment 3

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849904

Comment 4

[James Teh [:Jamie]]

Attachment: Bug 1880199: Make XULTabAccessible check for the presence of the pinned attribute rather than the explicit value "true".

In bug 1849904, the pinned attribute was changed to be a boolean attribute.
However, a11y was not updated accordingly and was still looking for the explicit value "true".
This meant that when pinned tabs were restored, their pinned state was not exposed to accessibility clients.
Fix this by checking for the presence of the pinned attribute instead, since presence means true and absence means false.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0e0920b02ea7
Make XULTabAccessible check for the presence of the pinned attribute rather than the explicit value "true". r=ayeddi

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/0e0920b02ea7

Comment 7

[Dianna Smith [:diannaS]]

:jamie is this important enough to uplift to Fx124? If not, please set status-firefox124 to wontfix

Comment 8

[James Teh [:Jamie]]

Attachment: Bug 1880199: Make XULTabAccessible check for the presence of the pinned attribute rather than the explicit value "true".

In bug 1849904, the pinned attribute was changed to be a boolean attribute.
However, a11y was not updated accordingly and was still looking for the explicit value "true".
This meant that when pinned tabs were restored, their pinned state was not exposed to accessibility clients.
Fix this by checking for the presence of the pinned attribute instead, since presence means true and absence means false.

Original Revision: https://phabricator.services.mozilla.com/D202372

Comment 9

[Phabricator Automation]

Uplift Approval Request

• String changes made/needed: none
• Risk associated with taking this patch: low
• Needs manual QE test: no
• Fix verified in Nightly: yes
• Explanation of risk level: Changes a single, specific check in the a11y code. It can't break any further than it already is.
• Code covered by automated testing: yes
• Steps to reproduce for manual QE testing: not applicable
• Is Android affected?: no
• User impact if declined: It will be difficult for screen reader users to determine which browser tabs are pinned.

Comment 10

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/37594569e2a4