1880200 - [wpt-sync] Sync PR 44573 - Use scroll margin for iframes' lazy loader.

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44573 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44573
Details from upstream follow.

Yotam Hacohen <[e-mail]> wrote:

Use scroll margin for iframes' lazy loader.

When creating an intersection observer for an iframe lazy loader we use
the margin values we get from GetLazyLoadingFrameMarginPx as the value
for the scroll margin and not for the root margin, to allow lazy
loading for iframes.

(Also including fix to the test expectations and a minor fix for one of
the tests)

Spec:
https://html.spec.whatwg.org/#lazy-load-root-margin

Bug: 40943726

Change-Id: Ifc15d79ced91e5e00d6c736907ea1feaa56a5532
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5293006
Auto-Submit: Yotam Hacohen \<[e-mail]>
Commit-Queue: Yotam Hacohen \<[e-mail]>
Reviewed-by: Traian Captan \<[e-mail]>
Reviewed-by: Xianzhu Wang \<[e-mail]>
Commit-Queue: Traian Captan \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1260177}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44573 applied with additional changes from upstream: 855f066245bfff9274c50217eae582d77a98b209

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=623d884a186e6eae905ce744e2de0776c534bd81

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
FAIL: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /html/semantics/embedded-content/the-iframe-element/iframe-loading-lazy-in-scroller-nested-2.html [wpt.fyi]
  • Test that lazy-loaded iframes load when near viewport.: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/104e4f765e18
[wpt PR 44573] - Use scroll margin for iframes' lazy loader., a=testonly

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/104e4f765e18