1880206 - video_capture_factory.cc:118:35: error: no member named 'set_allow_pipewire' in 'webrtc::VideoCaptureOptions'

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Mike Hommey [:glandium]]

When building Firefox for ppc64 or riscv64 linux, the build fails with:

[task 2024-02-14T01:44:36.049Z] 01:44:36    ERROR -  /builds/worker/checkouts/gecko/dom/media/systemservices/video_engine/video_capture_factory.cc:118:35: error: no member named 'set_allow_pipewire' in 'webrtc::VideoCaptureOptions'
[task 2024-02-14T01:44:36.049Z] 01:44:36     INFO -    118 |             mVideoCaptureOptions->set_allow_pipewire(false);
[task 2024-02-14T01:44:36.049Z] 01:44:36     INFO -        |             ~~~~~~~~~~~~~~~~~~~~~~^
[task 2024-02-14T01:44:36.050Z] 01:44:36     INFO -  1 error generated.

This is due to the code not being behind WEBRTC_USE_PIPEWIRE, which for some reason is not defined on those platforms.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1849608

:jgrulich, since you are the author of the regressor, bug 1849608, could you take a look?

For more information, please visit BugBot documentation.

Comment 2

[Jan Grulich]

Attachment: Bug 1880206 - Do not fallback from PipeWire to V4L2 on unsupported arches r=pehrsons

WEBRTC_USE_PIPEWIRE is not defined on ppc64 or riscv64 and this will end
up calling VideoCaptureOptions::set_allow_pipewire() that doesn't exist.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e36702fb3a6
Do not fallback from PipeWire to V4L2 on unsupported arches r=pehrsons

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/4e36702fb3a6