1880226 - [win] A Windows icon is displayed inside the About Firefox Nightly Window

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Attachment: image.png

Found in

• 124.0a1 (2024-02-13)

Affected versions

• 124.0a1 (2024-02-13)

Tested platforms

• Affected platforms: Windows 10x64
• Unaffected platforms: macOS 12, Ubuntu 22

Steps to reproduce

1. Open App Menu > Help > About Nightly.

Expected result

• No icon is displayed.

Actual result

• A Windows icon is displayed.

Regression range

• Last good revision: 011c3a1fb16cd9bff43d7206be75258524d629c8
  1:58.64 INFO: First bad revision: a00b8173b0b2773667d84e38c929a3195e317fd2
  1:58.64 INFO: Pushlog:
  https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=011c3a1fb16cd9bff43d7206be75258524d629c8&tochange=a00b8173b0b2773667d84e38c929a3195e317fd2
  Unfortunately, I don’t know which is the patch that causes this or if this is intentional, so I will leave a ni? on Emilio.

Additional notes

• Attached a screenshot.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1880226 - Approach 1: Keep WS_EX_DLGMODALFRAME for dialogs. r=#win-reviewers

This restores the behavior pre-patch.

Bug 1878037 removed this flag because it didn't affect borders, as
documented in MSDN:

https://learn.microsoft.com/en-us/windows/win32/winmsg/extended-window-styles

But apparently it has other side effects like suppressing the icon (?).

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1880226 - Approach 2 - Give the icon to the dialog window class. r=#win-reviewers

This changes behavior (keeps the icon, but fixes it), but I think this
is better / more consistent, and avoids relying on mis-documented window
style flags in MSDN.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Slight preference for comment 2.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5cff8819206
Approach 1: Keep WS_EX_DLGMODALFRAME for dialogs. r=win-reviewers,rkraesig

Comment 5

[Phabricator Automation]

Comment on attachment 9380299 [details]
Bug 1880226 - Approach 2 - Give the icon to the dialog window class. r=#win-reviewers

Revision D201894 was moved to bug 1880394. Setting attachment 9380299 [details] to obsolete.

Comment 6

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/a5cff8819206

Comment 7

[Alexandru Trif, Desktop Test Engineering [:atrif]]

Verified fixed with Firefox 124.0a1 (2024-02-15) on Windows 10x64. The icon is no longer displayed inside the About Firefox window and profile creation windows.