1880383 - [wpt-sync] Sync PR 44596 - [shared storage] Support cross-origin worklet

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44596 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44596
Details from upstream follow.

Yao Xiao <[e-mail]> wrote:

[shared storage] Support cross-origin worklet

For the sharedStorage.createWorklet() API, relax the restriction to
allow cross-origin script, in which case a cross-origin worklet will
be created.

We leverage the existing process allocation and management logic from
service workers and directly re-use
SiteInstanceImpl::CreateForServiceWorker(). To keep this CL focused,
renaming will occur in a separate CL, as it involves renaming other
downstream components like 'UnmatchedServiceWorkerProcessTracker'.

Explainer: https://github.com/WICG/shared-storage/pull/130
Spec: https://github.com/WICG/shared-storage/pull/131
Design doc:
https://docs.google.com/document/d/1QTaaroCMeFVZVghI6JkUcDvmDQEacjvpyTfk6mpvQhA/edit?usp=sharing&resourcekey=0-dqfVkB2DJcTzHLfJkern0Q

Bug: 325302836
Change-Id: I11c1fc87bc76f4400c54d9fa809349d1d1781247
Reviewed-on: https://chromium-review.googlesource.com/5296843
WPT-Export-Revision: efcadda7323f8ad43a4fe76be7163f48d33e7e18

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 44596 applied with additional changes from upstream: f02fb3cd6328b73b3a7839fa6da9230ca1de82fe

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=938337867a57077dcb939e734585966d4e2733fd

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 11 tests and 1 subtests

Status Summary

Firefox

OK : 11
FAIL: 11

Chrome

OK : 11
FAIL: 11

Safari

OK : 11
FAIL: 11

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /shared-storage/cross-origin-create-worklet-credentials-include.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with cross-origin module script and credentials "include": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/cross-origin-create-worklet-credentials-omit.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with cross-origin module script and credentials "omit": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/cross-origin-create-worklet-credentials-same-origin.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with cross-origin module script and credentials "same-origin": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/cross-origin-create-worklet-failure-missing-access-control-allow-credentials.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with cross-origin module script and credentials "include", and without the Access-Control-Allow-Credentials response header: FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/cross-origin-create-worklet-failure-missing-access-control-allow-origin.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with cross-origin module script and credentials "include", and without the Access-Control-Allow-Origin response header: FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/same-origin-add-module-credentials-include.tentative.https.sub.html [wpt.fyi]
  • addModule() with same-origin module script and credentials "include": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/same-origin-add-module-credentials-omit.tentative.https.sub.html [wpt.fyi]
  • addModule() with same-origin module script and credentials "omit": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/same-origin-add-module-credentials-same-origin.tentative.https.sub.html [wpt.fyi]
  • addModule() with same-origin module script and credentials "same-origin": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/same-origin-create-worklet-credentials-include.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with same-origin module script and credentials "include": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/same-origin-create-worklet-credentials-omit.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with same-origin module script and credentials "omit": FAIL (Chrome: FAIL, Safari: FAIL)
• /shared-storage/same-origin-create-worklet-credentials-same-origin.tentative.https.sub.html [wpt.fyi]
  • createWorklet() with same-origin module script and credentials "same-origin": FAIL (Chrome: FAIL, Safari: FAIL)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2ab59d57a8b3
[wpt PR 44596] - [shared storage] Support cross-origin worklet, a=testonly
https://hg.mozilla.org/integration/autoland/rev/a26c6ccfaf38
[wpt PR 44596] - Update wpt metadata, a=testonly

Comment 5

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/2ab59d57a8b3
https://hg.mozilla.org/mozilla-central/rev/a26c6ccfaf38