1880391 - Perma Puppeteer failure: "npm ERR! code EUSAGE | npm ERR! Invalid: lock file's @ljharb/through@2.3.11 does not satisfy @ljharb/through@2.3.12"

Status: RESOLVED FIXED

(Remote Protocol :: Agent, defect, P1)

Description

[Cosmin Sabou [:CosminS]]

These are failing even on previous green runs that points to an off-tree issue.

Failure log: https://treeherder.mozilla.org/logviewer?job_id=447302612&repo=autoland

Raw log: https://firefoxci.taskcluster-artifacts.net/Azgz4CZGTnCid7vtvZeZsw/0/public/logs/live_backing.log

Henrik, could you please have a look over this one? Thank you.

[task 2024-02-14T21:45:46.008Z] npm WARN EBADENGINE }
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! code EUSAGE
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! `npm ci` can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! Invalid: lock file's @ljharb/through@2.3.11 does not satisfy @ljharb/through@2.3.12
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! Clean install a project
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! Usage:
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! npm ci
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! Options:
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [-S|--save|--no-save|--save-prod|--save-dev|--save-optional|--save-peer|--save-bundle]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [-E|--save-exact] [-g|--global] [--global-style] [--legacy-bundling]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [--omit <dev|optional|peer> [--omit <dev|optional|peer> ...]]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [--strict-peer-deps] [--no-package-lock] [--foreground-scripts]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [--ignore-scripts] [--no-audit] [--no-bin-links] [--no-fund] [--dry-run]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [-w|--workspace <workspace-name> [-w|--workspace <workspace-name> ...]]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! [-ws|--workspaces] [--include-workspace-root] [--install-links]
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! aliases: clean-install, ic, install-clean, isntall-clean
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! Run "npm help ci" for more info
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR! A complete log of this run can be found in:
[task 2024-02-14T21:45:46.008Z] 
[task 2024-02-14T21:45:46.008Z] npm ERR!     /builds/worker/.npm/_logs/2024-02-14T21_45_44_064Z-debug-0.log
[task 2024-02-14T21:45:46.008Z] 
[taskcluster 2024-02-14 21:45:48.132Z] === Task Finished ===
[taskcluster 2024-02-14 21:45:48.561Z] Unsuccessful task run with exit code: 1 completed in 249.068 seconds

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The underlying failure here is:

npm ci can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with npm install before continuing.

I can reproduce locally. Let me see if I can find a quick fix for now.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The last release of the related npm package https://www.npmjs.com/package/@ljharb/through was 21 days ago. So not sure why it started failing now?

Upgrading our package-lock.json file to version 2.3.12 fixes it. Maybe the problem is that this npm package is not listed in Puppeteer's package.json file?

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Most likely the problem here comes from recent landings of node changes on bug 1879465, bug 1879465 or bug 1879466. Whereby none of these changed the node version for the Puppeteer job yet.

So the regression started here:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=pup&revision=d6732fe2041a1e6da2c6d9d7d02ca4e327319c91

Comment 4

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Attachment: Bug 1880391 - [puppeteer] Upgrade node module ljharb/through to fix bustage.

Comment 5

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Note that the attached patch will fix the bustage but the EBADENGINE warning is still visible in the logs:
https://treeherder.mozilla.org/logviewer?job_id=447406043&repo=try&lineNumber=96

But maybe this only exists because some packages want Node 18 and it will be solved when we do this upgrade on bug 1875239.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba64473ee76b
[puppeteer] Upgrade node module ljharb/through to fix bustage. r=webdriver-reviewers,Sasha

Comment 7

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/ba64473ee76b

Comment 8

[Intermittent Failures Robot]

16 failures in 374 pushes (0.043 failures/push) were associated with this bug yesterday.

Repository breakdown:

• autoland: 8
• mozilla-central: 8

Platform and build breakdown:

• linux1804-64: 16
  • opt: 16

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1880391&startday=2024-02-15&endday=2024-02-15&tree=all

Comment 9

[Intermittent Failures Robot]

18 failures in 3125 pushes (0.006 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 10
• autoland: 8

Platform and build breakdown:

• linux1804-64: 18
  • opt: 18

For more details, see:
https://treeherder.mozilla.org/intermittent-failures/bugdetails?bug=1880391&startday=2024-02-12&endday=2024-02-18&tree=all

Comment 10

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The underlying failure is fixed and the EBADENGINE warning doesn't cause issues. I'm closing the bug but will keep the need-info request for Mike.

Comment 11

[Mike Hommey [:glandium]]

(In reply to Henrik Skupin [:whimboo][⌚️UTC+1] from comment #3)

Most likely the problem here comes from recent landings of node changes on bug 1879465, bug 1879465 or bug 1879466. Whereby none of these changed the node version for the Puppeteer job yet.

So the regression started here:
https://treeherder.mozilla.org/jobs?repo=mozilla-central&searchStr=pup&revision=d6732fe2041a1e6da2c6d9d7d02ca4e327319c91

Considering that push had nothing node related in it, my guess is external forces (e.g. npm registry). And guess what, retriggering the green job on the parent push returned the same failure. So it had nothing to do with something in tree.