Closed
Bug 1880403
Opened 1 year ago
Closed 1 year ago
Re-enable Yelp suggestions when sponsored suggestions are enabled
Categories
(Firefox :: Address Bar, defect, P1)
Firefox
Address Bar
Tracking
()
VERIFIED
FIXED
124 Branch
People
(Reporter: adw, Assigned: adw)
References
Details
(Whiteboard: [sng])
Attachments
(1 file)
We need to add "suggest.quicksuggest.sponsored"
to enablingPreferences
here: https://searchfox.org/mozilla-central/rev/b5b551329484a67f2abb4bae50411b93d5851733/browser/components/urlbar/private/YelpSuggestions.sys.mjs#38
Otherwise when sponsored suggestions are disabled and then enabled, Yelp will remain disabled. Importantly, this is true for the whole Suggest user population because of the way that Suggest dynamically flips on the sponsored pref at startup.
Updated•1 year ago
|
Assignee | ||
Comment 1•1 year ago
|
||
Depends on D201302
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5f1d087788bb
Re-enable Yelp suggestions when sponsored suggestions are enabled. r=daisuke
Comment 3•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox124:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 124 Branch
Updated•1 year ago
|
Flags: qe-verify+
Comment 4•1 year ago
|
||
I have verified this on the latest Beta 124.0b1 (Build ID: 20240219092531) and latest Nightly 125.0a1 (Build ID: 20240221090755) on Windows 10 x64, macOS 13.1 and Linux Mint 20.1.
- The Yelp suggestions are also re-enabled if the sponsored suggestions are disabled and then enabled.
You need to log in
before you can comment on or make changes to this bug.
Description
•