1880410 - Cleanup parts of search telemetry

Status: RESOLVED FIXED

(Firefox :: Search, task, P2)

Description

[James Teow [:jteow]]

There are a couple places in SearchTelemetry and SearchSERPTelemetryChild that could be improved without a change of functionality.

1. Moving the explicit calls to remove event listeners in the pagehide event
2. Renaming some of the properties passed to the engagement report as target to better reflect how it'll be reported
3. Adding an observer of page actions so that tests can use them.

These changes alone shouldn't affect search telemetry, but will make it easier to do some other code refactoring.

Comment 1

[James Teow [:jteow]]

Attachment: Bug 1880410 - Clean up parts of search telemetry - r?scunnane!

Largely non-functional changes:

• The pagehide callback can live in the top level pagehide event.
• Moving the submitted check into the callback will make it easier to refactor
  the helper that adds event listeners.
• Changing the callbacks to use target as the name will make it easier to
  remember that the target is potentially overwritable.
• waitForPageWithAction can be used in future tests.

Depends on D202035

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9209f2fb0d6
Clean up parts of search telemetry - r=scunnane

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/e9209f2fb0d6