1880416 - Problems with ingest in the Suggest Rust backend

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Drew Willcoxon :adw]

I think there are a couple problems with ingest in the Rust backend:

1. If multiple ingests happen one after the other, they can hit the Rust component at the same time. I think this might be the cause of bugs in tests like bug 1880388, where the component tries to create the meta table when it already exists.
2. Bug 1878444 caused #ingestPromise to be resolved before #ingest() finishes. Probably not good.

I think these problems might be the cause of recent intermittent failures like bug 1880388, bug 1879226, bug 1832413, bug 1880406, bug 1808802, maybe others. I've definitely noticed new-ish failures on try recently.

Comment 1

[Drew Willcoxon :adw]

Sorry, meant to file this in Address Bar.

Comment 2

[Drew Willcoxon :adw]

Attachment: Bug 1880416 - Fix problems with ingest in the Suggest Rust backend.

This makes sure only one ingest happens at a time. If a new ingest starts while
one is ongoing, it will await the ingest promise and then start. If many ingests
try to start at the same time, the last one will continue and the others will
bail due to #ingestInstance.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d725049e644
Fix problems with ingest in the Suggest Rust backend. r=daisuke

Comment 4

[Iulian Moraru]

https://hg.mozilla.org/mozilla-central/rev/5d725049e644