Closed Bug 1880480 Opened 2 years ago Closed 6 months ago

ESC key should not save modified data in `Edit bookmark` from Star Icon

Categories

(Firefox :: Bookmarks & History, defect, P3)

Product:
Firefox
Component:
Bookmarks & History
Platform:
Desktop
Windows 10
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
149 Branch
Tracking Flags:
Tracking Status
firefox149 --- verified
firefox150 --- verified

People

(Reporter: alice0775, Assigned: daisuke)

References

Details

(Keywords: papercut, Whiteboard: [sng][search-papercut])

Attachments

(1 file)

Bug 1880480: Do not update bookmark information when hiding the popup by ESC key
48 bytes, text/x-phabricator-request
Details | Review

Similar to Bug 1718982, but this is about editing from the star icon

Steps to reproduce:

  1. Open a bookmarked page
  2. Click Star Icon to open Edit Bookmark Dialog
  3. Edit something(name, location, tags)
  4. Press Esc key to cancel this editing
  5. Click Star Icon again to open Edit Bookmark Dialog

Actual results:
Modified data are saved.

Expected Results:
All changes should be abandoned.

Summary: ESC key should not save modified data in `Edit bookmark` from Start Icon → ESC key should not save modified data in `Edit bookmark` from Star Icon
See Also: → 1880613

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Flags: needinfo?(mak)
Severity: -- → S3
Flags: needinfo?(mak)
Keywords: papercut
Priority: -- → P3

Given that pressing Enter also saves the changes and closes the popup, we think it is reasonable for Escape to not save the changes (and close the popup).

Whiteboard: [sng][search-papercut]
Assignee: nobody → daisuke
Status: NEW → ASSIGNED
Pushed by dakatsuka.birchill@mozilla.com: https://github.com/mozilla-firefox/firefox/commit/eb006b6fc446 https://hg.mozilla.org/integration/autoland/rev/b8a23120e37f Do not update bookmark information when hiding the popup by ESC key r=places-reviewers,Standard8

https://hg.mozilla.org/mozilla-central/rev/b8a23120e37f

Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox149: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 149 Branch
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49]
Flags: qe-verify+
QA Whiteboard: [qa-triage-done-c150/b149] [qa-ver-needed-c150/b49] → [qa-triage-done-c150/b149][qa-ver-needed-c150/b49]
QA Whiteboard: [qa-triage-done-c150/b149][qa-ver-needed-c150/b49] → [qa-triage-done-c150/b149][qa-ver-needed-c150/b149]

Reproduced the issue on Nightly 124.0a1 (2024-02-15) on Windows 11.
Verified as fixed on Windows 11, Ubuntu 22 and macOS 13 using the latest Nightly 150.0a1 (2026-03-02) and Firefox 149 Beta 3.

Status: RESOLVED → VERIFIED
QA Whiteboard: [qa-triage-done-c150/b149][qa-ver-needed-c150/b149] → [qa-triage-done-c150/b149][qa-ver-done-c150/b149]
status-firefox149: fixed → verified
status-firefox150: --- → verified
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: