1880480 - ESC key should not save modified data in `Edit bookmark` from Star Icon

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[Alice0775 White]

Similar to Bug 1718982, but this is about editing from the star icon

Steps to reproduce:

1. Open a bookmarked page
2. Click Star Icon to open Edit Bookmark Dialog
3. Edit something(name, location, tags)
4. Press Esc key to cancel this editing
5. Click Star Icon again to open Edit Bookmark Dialog

Actual results:
Modified data are saved.

Expected Results:
All changes should be abandoned.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:mak, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Mark Banner (:standard8)]

Given that pressing Enter also saves the changes and closes the popup, we think it is reasonable for Escape to not save the changes (and close the popup).

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1880480: Do not update bookmark information when hiding the popup by ESC key

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://github.com/mozilla-firefox/firefox/commit/eb006b6fc446
https://hg.mozilla.org/integration/autoland/rev/b8a23120e37f
Do not update bookmark information when hiding the popup by ESC key r=places-reviewers,Standard8

Comment 5

[amarc]

https://hg.mozilla.org/mozilla-central/rev/b8a23120e37f