1880534 - Network limiter doesn't throttle websocket connections

Status: UNCONFIRMED

(Core :: Networking: WebSockets, defect, P2)

Description

[marsal2000]

Steps to reproduce:

Open site with streaming through websocket instead of webrtc
Open Devtools
Navitage to Network
Enable Throttling

Actual results:

The network did not get throttled on the page, no matter the settings

Expected results:

The websocket traffic should've been throttled

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Networking: WebSockets' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

@valentin - do you know how we're doing devtools throttling?

Comment 3

[Valentin Gosu [:valentin] (he/him) {{ FYI: OOO 14 June - 4 August }}]

The thottling happens in devtools here.
While the initial channel to deal with the WS upgrade would be throttled, websocket channels might not.

I think we need additional work to support this for websockets.
With downloads, we probably need to change WebSocketChannel::OnInputStreamReady so we don't read more than allowed.
With uploads either WebSocketChannel::OnOutputStreamReady or WebSocketChannel::EnqueueOutgoingMessage

Comment 4

[Sunil Mayya]

We might have a similar problem for WebTransport as well.