1880535 - Enable some more recommended rules

Status: RESOLVED FIXED

(Developer Infrastructure :: Lint and Formatting, task, P3)

Description

[Mark Banner (:standard8)]

There are a few recommended ESLint rules (or will be recommended in ESLint v9) that we should enable, these have zero or only a few failures.

• constructor-super
• no-empty-static-block
• no-new-native-nonconstructor
• require-yield
• no-unused-private-class-members

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1880535 - Enable ESLint recommended rules constructor-super, no-empty-static-block, no-new-native-nonconstructor. r?Gijs!

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1880535 - Enable ESLint recommended rule require-yield. r?Gijs!

Comment 3

[Mark Banner (:standard8)]

Attachment: Bug 1880535 - Enable ESLint rule no-unused-private-class-members. r?Gijs!

Comment 4

[Mark Banner (:standard8)]

Try push: https://treeherder.mozilla.org/jobs?repo=try&revision=0c411a709d8302c6693ace4e3ce045dded75e914

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c188a69b0a5e
Enable ESLint recommended rules constructor-super, no-empty-static-block, no-new-native-nonconstructor. r=Gijs
https://hg.mozilla.org/integration/autoland/rev/b2b415433ad4
Enable ESLint recommended rule require-yield. r=Gijs,devtools-reviewers,dom-storage-reviewers,nchevobbe,janv
https://hg.mozilla.org/integration/autoland/rev/871e61e4aa93
Enable ESLint rule no-unused-private-class-members. r=Gijs,webdriver-reviewers,webcompat-reviewers,extension-reviewers,application-update-reviewers,devtools-reviewers,translations-reviewers,bytesized,twisniewski,jhirsch,robwu,whimboo

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/c188a69b0a5e
https://hg.mozilla.org/mozilla-central/rev/b2b415433ad4
https://hg.mozilla.org/mozilla-central/rev/871e61e4aa93