Closed
Bug 1880573
Opened 1 year ago
Closed 1 year ago
Opt for one standard value for "--text-color-deemphasized" token in `tokens-shared.css`
Categories
(Toolkit :: Themes, task, P3)
Toolkit
Themes
Tracking
()
RESOLVED
FIXED
125 Branch
Tracking | Status | |
---|---|---|
firefox125 | --- | fixed |
People
(Reporter: jules, Assigned: jules)
References
(Blocks 1 open bug)
Details
(Whiteboard: [recomp])
Attachments
(1 file)
Tokens either live in tokens-shared.css
or have different values between tokens-brand.css
and tokens-platform.css
contexts (learn more). However, --text-color-deemphasized
is listed as slightly different values between tokens-shared.css
and tokens-brand.css
, so we could benefit from standardizing this.
Upon looking at color contrast, let's just opt for using the light value set in tokens-brand.css (color-mix(in srgb, currentColor 69%, transparent
) as the default value and keep it in tokens-shared.css and get rid of the other custom value in tokens-brand.css.
Updated•1 year ago
|
Updated•1 year ago
|
Whiteboard: [fidefe-reusable-components] → [recomp]
Updated•1 year ago
|
Severity: -- → N/A
Priority: -- → P3
Assignee | ||
Comment 1•1 year ago
|
||
Updated•1 year ago
|
Assignee: nobody → jules
Attachment #9382126 -
Attachment description: WIP: Bug 1880573 - Opt for one standard `--text-color-deemphasized` value → Bug 1880573 - Opt for one standard `--text-color-deemphasized` value r?#desktop-theme-reviewers,#reusable-components-reviewers
Status: NEW → ASSIGNED
Pushed by jsimplicio@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/bcc6d92f004f
Opt for one standard `--text-color-deemphasized` value r=desktop-theme-reviewers,reusable-components-reviewers,emilio,mstriemer
Comment 3•1 year ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 1 year ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•