1880664 - The same Yelp result is still triggered after previously being dismissed using the “Not relevant” option from the Feedback menu

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect)

Description

[Carmen Fat [:cfat] - Ecosystem QA]

[Affected versions]:

• Firefox Nightly 124.0a1 - Build ID: 20240216094648

[Affected Platforms]:

• Windows 10 x64
• macOS 12.6.1
• Linux Ubuntu 20.04 x64

[Prerequisites]:

• Have the following prefs set with the values to enable the feature:
  browser.search.region = US (connect to a VPN server if outside US)
  browser.urlbar.quicksuggest.rustEnabled = true
  browser.urlbar.suggest.yelp = true
  browser.urlbar.yelp.featureGate = true
  browser.urlbar.yelp.priority = true

[Steps to reproduce]:

1. Open the browser with the profile from the prerequisites.
2. Type the “ramen” string in the Address Bar.
3. Click the “Feedback” button.
4. Click the “Don’t show this” option.
5. Dismiss the suggestion by clicking the “Not relevant” option.
6. Click outside the Address Bar drop down.
7. Click inside the Address Bar and observe the behavior.

[Expected result]:

• The Yelp suggestion for "ramen" is not triggered.

[Actual result]:

• The Yelp suggestion is displayed again.

[Notes]:

• This issue affects Yelp results displayed on both Top Pick and Firefox Suggest locations.
• Here is a screen recording of the issue.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Thank you very much for the report, Carmen!
I also could reproduce this issue. I will take a look at it.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1880664: Use URL provided by Rust as is to block

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3cc9041fe024
Use URL provided by Rust as is to block r=adw

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/3cc9041fe024

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:daisuke, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[Daisuke Akatsuka (:daisuke)]

Comment on attachment 9380933 [details]
Bug 1880664: Use URL provided by Rust as is to block

Beta/Release Uplift Approval Request

• User impact if declined: Suggestions can not be blocked, even if the user clicks "not relevant" menu item.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The changes are only two lines and it affects only Yelp suggestion.
• String changes made/needed: None
• Is Android affected?: Unknown

Comment 7

[Dianna Smith [:diannaS]]

Comment on attachment 9380933 [details]
Bug 1880664: Use URL provided by Rust as is to block

Approved for 124.0b3

Comment 8

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/260ce9f8958f

Comment 9

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240222100216) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 13.1.

• The Yelp result is no longer displayed if previously dismissed using the “Not relevant” option.

However, we have noticed that the same subject which was previously dismissed, will be displayed again when also adding pre-, post-, or location-modifiers:
E.g. “ramen” was dismissed via “Not relevant” option

There are different results about triggering the Yelp suggestion with the following combinations:

• (subject) ramen - Yelp suggestion not triggered
• (pre-modifier+subject) best ramen - Yelp suggestion triggered
• (subject+post-modifier) ramen delivery - Yelp suggestion triggered
• (subject+location-modifier) ramen nearby - Yelp suggestion triggered
• (subject+location-sign) ramen near - Yelp suggestion not triggered
• (subject+yelp-modifier) ramen yelp - Yelp suggestion not triggered

Could you please confirm if the results mentioned above are the expected ones?

Comment 10

[Drew Willcoxon :adw]

Hi Carmen, yes that's correct. Dismissals are based on the URL, excluding the UTM params and the automatically added city (if any). Pre- and post-modifiers are included in the URL, which you can see in the find_desc param. That means each new modifier you use will cause the suggestion to be shown again, even if you use the same subject. OTOH if you use the same modifier and subject in the same order, you shouldn't see it again.

Comment 11

[Carmen Fat [:cfat] - Ecosystem QA]

Thank you for the confirmation, Drew.
Since the scenarios mentioned in comment 9 are the expected ones, we can mark this report as Verified for both Nightly 125.0a1 (Build ID: 20240226165659) and Beta 124.0b4 (Build ID: 20240226091939).

• The Yelp suggestion is no longer displayed if previously dismissed using the “Not relevant” option.