1880698 - Dropping files from file manager stopped working

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[The 8472]

Attempting to drop a file from a file manager (nemo) to the drop area on https://catbox.moe/ started to fail recently on nightly (checked dev edition, it still works there).
The other direction, dragging an image from a site to the file manager, continues to work.

Name Firefox
Version 124.0a1
Build ID 20240216094648

Comment 1

[Alice0775 White]

[Tracking Requested - why for this release]:File upload does not work on linux.

I can reproduce this on Nightly124.0a1 Ubuntu22.04 and Linux Mint 21.3 Cinnamon.

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=2b4e9ee6225f1183da45d24404e72f48e3803f08&tochange=bdabd37473ed5839557b90557ee6ca684a0d4500

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

:jhorak, since you are the author of the regressor, bug 1786251, could you take a look?

For more information, please visit BugBot documentation.

Comment 3

[Jan Horak [:jhorak]]

I'm on it.

Comment 4

[Jan Horak [:jhorak]]

Attachment: Bug 1880698 Use drag uris when converting to text/uri-list; r=stransky

When trying to convert the application/x-moz-file drag target to text/uri-list use the
target drag uris list instead of drag data.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1786251

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/63c20169e83a
Use drag uris when converting to text/uri-list; r=stransky

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/63c20169e83a

Comment 8

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:jhorak, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Comment on attachment 9381020 [details]
Bug 1880698 Use drag uris when converting to text/uri-list; r=stransky

Beta/Release Uplift Approval Request

• User impact if declined: D&D in Firefox doesn't work for files.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor tweak to recent D&D code.
• String changes made/needed:
• Is Android affected?: No

Comment 11

[Dianna Smith [:diannaS]]

Comment on attachment 9381020 [details]
Bug 1880698 Use drag uris when converting to text/uri-list; r=stransky

Approved for 124.0b5

Comment 12

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/73323a2df76b