1880781 - 33.35 - 7.4% damp console.typing / damp console.autocomplete + 2 more (Linux) regression on Tue February 13 2024

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect)

Description

[Nicolas Chevobbe [:nchevobbe]]

Perfherder has detected a devtools performance regression from push c5320acccd4a760b0ae41149fcdd8fe44b658ee7. As author of one of the patches included in that push, we need your help to address this regression.

Regressions:

Ratio	Test	Platform	Options	Absolute values (old vs new)
33%	damp console.typing	linux1804-64-shippable-qr	e10s fission stylo webrender	418.79 -> 558.45
27%	damp console.typing	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	408.70 -> 518.82
8%	damp console.autocomplete	linux1804-64-shippable-qr	e10s fission stylo webrender	723.33 -> 783.85
7%	damp console.autocomplete	linux1804-64-shippable-qr	e10s fission stylo webrender-sw	720.04 -> 773.34

Details of the alert can be found in the alert summary, including links to graphs and comparisons for each of the affected tests. Please follow our guide to handling regression bugs and let us know your plans within 3 business days, or the patch(es) may be backed out in accordance with our regression policy.

If you need the profiling jobs you can trigger them yourself from treeherder job view or ask a sheriff to do that for you.

You can run these tests on try with ./mach try perf --alert 41489

For more information on performance sheriffing please see our FAQ.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

I'll look at it. Nicolas, is it possible to run the perf tests locally? Bug 1875369 changes how window is created/closed on Linux (we do rendering shutdown on close) so we may hit regression if popup is closed for instance. I wonder if there's any tooltip / content menu show during the test or so?

Comment 2

[Nicolas Chevobbe [:nchevobbe]]

(In reply to Martin Stránský [:stransky] (ni? me) from comment #1)

I'll look at it. Nicolas, is it possible to run the perf tests locally?

yes, you can run the typing test with ./mach talos-test --suite damp-webconsole --subtest console.typing --cycles 1 --tpcycles 1 --tppagecycles 1 --gecko-profile --gecko-profile-entries 1000000000 --gecko-profile-interval 1

Bug 1875369 changes how window is created/closed on Linux (we do rendering shutdown on close) so we may hit regression if popup is closed for instance. I wonder if there's any tooltip / content menu show during the test or so?

The test is checking the webconsole typing, which triggers an autocomplete popup

Comment 3

[Martin Stránský [:stransky] (ni? me)]

(In reply to Nicolas Chevobbe [:nchevobbe] from comment #2)

(In reply to Martin Stránský [:stransky] (ni? me) from comment #1)

I'll look at it. Nicolas, is it possible to run the perf tests locally?

yes, you can run the typing test with ./mach talos-test --suite damp-webconsole --subtest console.typing --cycles 1 --tpcycles 1 --tppagecycles 1 --gecko-profile --gecko-profile-entries 1000000000 --gecko-profile-interval 1

Thanks, will try that.

Bug 1875369 changes how window is created/closed on Linux (we do rendering shutdown on close) so we may hit regression if popup is closed for instance. I wonder if there's any tooltip / content menu show during the test or so?

The test is checking the webconsole typing, which triggers an autocomplete popup

I see, that may be the issue here.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Should be addressed by Bug 1880323.

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1875369