1881123 - Use res_query on musl libc instead of res_nquery

Status: RESOLVED FIXED

(Core :: Networking: DNS, defect, P2)

Description

[Patrycja Rosa [:ptrcnull] (she/her)]

musl doesn't have res_nquery - an easy fix would be to make the res_nquery depend on GNU Libc as well as XP_LINUX, and let musl builds fall back to the (currently) macOS branch with res_query

Comment 1

[Valentin Gosu [:valentin]]

I guess we can gate this on HAVE_RES_NINIT instead.

Comment 2

[:LinuxUserGD]

Reproducible with firefox-123.0 (Gentoo Linux amd64 musl libc)

diff --git a/netwerk/dns/PlatformDNSUnix.cpp b/netwerk/dns/PlatformDNSUnix.cpp
index 753d786..14f7923 100644
--- a/netwerk/dns/PlatformDNSUnix.cpp
+++ b/netwerk/dns/PlatformDNSUnix.cpp
@@ -32,7 +32,7 @@ nsresult ResolveHTTPSRecordImpl(const nsACString& aHost, uint16_t aFlags,
   rv = packet.FillBuffer(
       [&](unsigned char response[DNSPacket::MAX_SIZE]) -> int {
         int len = 0;
-#if defined(XP_LINUX)
+#if defined(XP_LINUX) && defined(HAVE_RES_NINIT)
         len = res_nquery(&_res, host.get(), ns_c_in,
                          nsIDNSService::RESOLVE_TYPE_HTTPSSVC, response,
                          DNSPacket::MAX_SIZE);

Comment 3

[Valentin Gosu [:valentin]]

I think this was fixed by bug 1881437.
Please let me know if you're still seeing failures.