1881189 - Add pingTypes for each surface that uses the aboutwelcome bundle

Status: RESOLVED DUPLICATE of bug 1927849

(Firefox :: Messaging System, task, P2)

Description

[Shane Hughes [:aminomancer]]

Right now, all telemetry events coming from aboutwelcome.bundle.js are missing a pingType property, because they aren't coming from TelemetryFeed, which adds the pingType for other surfaces. pingType is useful because it helps us distinguish between events in aggregate on Redash/Looker. So we'll need to add some logic to track where the message is coming from and/or what its template is, so that AboutWelcomeTelemetry can identify the right pingType for the message and add it to the event object.

This includes about:welcome onboarding, spotlights, feature callouts, and shopping onboarding & surveys. Each one should have its own pingType, I think. Complicating matters is that about:welcome and shopping don't actually have template values, as they aren't really messages, strictly speaking. Whereas other messages look like message: { id:, content: {...} }, about:welcome and shopping messages look like content: {...}. In other words, they are just the content property, i.e. missing the top level that messages normally have. But they do send the same telemetry messages send, so they need to have a pingType nonetheless.

One option would be to refactor things so that these special surfaces do have the top level that messages normally have. That might solve other problems in the future. But I think the simplest approach would be to add an identifying property to the return value of AWGetFeatureConfig (which is defined individually by each surface).