Closed
Bug 1881310
Opened 1 years ago
Closed 1 years ago
Give oomTest a dummy definition in builds where it's not present
Categories
(Core :: JavaScript Engine, task)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
125 Branch
Tracking | Status | |
---|---|---|
firefox125 | --- | fixed |
People
(Reporter: jonco, Assigned: jonco)
Details
Attachments
(2 files)
Many times I've added a use of oomTest only to have my tests fail because it's not present in release builds. This should get a dummy definition in the same way as we do for other optional testing functions.
Assignee | ||
Comment 1•1 years ago
|
||
This adds dummy functions to the main global only. Tests that depend on these
being present in other globals must now check 'hasFunction'.
Assignee | ||
Comment 2•1 years ago
|
||
Pushed by jcoppeard@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/41cd5f30be4b
Part 1: Generate dummy functions for OOM testing functions where these not present in the build r=sfink
https://hg.mozilla.org/integration/autoland/rev/3f4668f15c0e
Part 2: Remove unnecessary checks for missing functions in jit-tests r=sfink
https://hg.mozilla.org/mozilla-central/rev/41cd5f30be4b
https://hg.mozilla.org/mozilla-central/rev/3f4668f15c0e
Status: NEW → RESOLVED
Closed: 1 years ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•