Closed Bug 1881327 Opened 9 months ago Closed 8 months ago

Convert current clear history dialog pref remembering logic to using <template>

Categories

(Toolkit :: Data Sanitization, task, P2)

task

Tracking

()

RESOLVED FIXED
126 Branch
Tracking Status
firefox126 --- fixed

People

(Reporter: hsohaney, Assigned: hsohaney)

References

(Blocks 1 open bug)

Details

Attachments

(3 files)

We should use <template> instead of .remove() to keep unique id's between the different clear history dialog contexts.

Assignee: nobody → hsohaney
Attachment #9382694 - Attachment description: WIP: Bug 1881327 - Convert current clear history dialog pref remembering logic to using <template>. WIP → Bug 1881327 - Convert new clear history dialog context switching logic to using html <template>. r?pbz
Attachment #9388199 - Attachment description: Bug 1881327 - (part 2) added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz → WIP: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. WIP
Attachment #9382694 - Attachment description: Bug 1881327 - Convert new clear history dialog context switching logic to using html <template>. r?pbz → Bug 1881327 - (part 1) Convert new clear history dialog context switching logic to using html <template>. r?pbz
Attachment #9388199 - Attachment description: WIP: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. WIP → Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz
Attachment #9389511 - Attachment description: WIP: Bug 1881327 - (part 3) Testing for clear history dialog resizing. WIP → Bug 1881327 - (part 3) Testing for clear history dialog resizing. r?pbz
Attachment #9388199 - Attachment description: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz → Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. WIP
Attachment #9388199 - Attachment description: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. WIP → Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz
Attachment #9388199 - Attachment description: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz → WIP: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. WIP
Attachment #9388199 - Attachment description: WIP: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. WIP → Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz
Attachment #9388199 - Attachment description: Bug 1881327 - (part 2) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz → Bug 1881327 - (part 1) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r?pbz
Attachment #9389511 - Attachment description: Bug 1881327 - (part 3) Testing for clear history dialog resizing. r?pbz → Bug 1881327 - (part 2) Testing for clear history dialog resizing. r?pbz
Attachment #9382694 - Attachment description: Bug 1881327 - (part 1) Convert new clear history dialog context switching logic to using html <template>. r?pbz → WIP: Bug 1881327 - Convert new clear history dialog context switching logic to using html <template>. WIP
Pushed by hsohaney@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/58e7aa9620ec (part 1) Added dialog box resizing for the new clear history dialog to account for wrapping due to localization. r=pbz https://hg.mozilla.org/integration/autoland/rev/95309bd3ea79 (part 2) Testing for clear history dialog resizing. r=pbz
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: