Closed
Bug 1881487
Opened 9 months ago
Closed 9 months ago
Update unicode-bidi to use the smallvec optimization
Categories
(Core :: Internationalization, enhancement)
Core
Internationalization
Tracking
()
RESOLVED
FIXED
125 Branch
Tracking | Status | |
---|---|---|
firefox125 | --- | fixed |
People
(Reporter: jfkthame, Assigned: jfkthame)
References
Details
Attachments
(2 files)
This substantially reduces heap allocations during bidi resolution, and should result in a small but measureable perf improvement.
Assignee | ||
Comment 1•9 months ago
|
||
(See https://github.com/servo/unicode-bidi/pull/127 for the upstream optimization that we're incorporating here.)
Assignee | ||
Comment 2•9 months ago
|
||
Updated•9 months ago
|
Assignee: nobody → jfkthame
Status: NEW → ASSIGNED
Assignee | ||
Comment 3•9 months ago
|
||
Updated•9 months ago
|
Attachment #9381988 -
Attachment description: Bug 1881487 - Update unicode-bidi to pick up newly-added smallvec support. → Bug 1881487 - Update unicode-bidi to pick up newly-added smallvec support. r=#platform-i18n-reviewers
Updated•9 months ago
|
Attachment #9381990 -
Attachment description: Bug 1881487 - Run './mach vendor rust' to get the unicode-bidi and smallvec updates. → Bug 1881487 - Run './mach vendor rust' to get the unicode-bidi and smallvec updates. r=#platform-i18n-reviewers
Pushed by jkew@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/771b0739d524
Update unicode-bidi to pick up newly-added smallvec support. r=platform-i18n-reviewers,supply-chain-reviewers,nordzilla
https://hg.mozilla.org/integration/autoland/rev/561af3572275
Run './mach vendor rust' to get the unicode-bidi and smallvec updates. r=platform-i18n-reviewers,nordzilla
Comment 5•9 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/771b0739d524
https://hg.mozilla.org/mozilla-central/rev/561af3572275
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
status-firefox125:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
Comment 6•8 months ago
|
||
== Change summary for alert #41572 (as of Sat, 24 Feb 2024 19:57:15 GMT) ==
Improvements:
Ratio | Test | Platform | Options | Absolute values (old vs new) |
---|---|---|---|---|
5% | damp custom.jsdebugger.open-large-minified-file.DAMP | linux1804-64-shippable-qr | e10s fission stylo webrender | 1,206.71 -> 1,145.13 |
For up to date results, see: https://treeherder.mozilla.org/perfherder/alerts?id=41572
You need to log in
before you can comment on or make changes to this bug.
Description
•