1881506 - Mouse click event stuck when using right mouse click during taking a screenshot

Status: VERIFIED FIXED

(Firefox :: Screenshots, defect, P3)

Description

[Bogdan Maris, Desktop QA [Holiday+PTO 1-6 May]]

Attachment: Video showing the issue on mac

Found in

• Firefox 124.0b2

Affected versions

• Firefox 115.8.0esr
• Firefox 124.0b2
• Firefox 123.0
• Nightly 87.0a1

Tested platforms

• Affected platforms: MacOS 13.6, Ubuntu 22.04 and Windows 11.
• Unaffected platforms: none

Preconditions

• Have a 2 button mouse connected to the device. (trackpad or magic mouse will not work)

Steps to reproduce

1. Visit a random webpage
2. Press shift+cmd+S or click the screenshot button (is located in Customize and needs to be added in the toolbar).
3. Left click to select a screenshot area
4. Use the right click of the mouse at the same time the left click is used
5. Release the left click
6. Select the "Select all" option from context menu
7. Move the mouse without touching any mouse buttons

Expected result

• I believe the right click context menu should be disabled when selecting an area to take a screenshot, same as its done for Print preview for example. Once I release the left click button the options to download, copy or close appear.

Actual result

• The mouse click button is stuck and the screenshot area can be changed even if no physical button is pressed on the mouse. On Mac the selection area is stuck in one place but in can still be moved if right clicking over and over in the page (see the screencast attached)

Regression range

• Not a recent regression since its reproducible on Firefox 87 as well and I think this has always been the same. Not sure when Screenshots was first implemented though. I am unable to open older builds on Ubuntu/Mac13 though so I would say that this is not a regression.

Additional notes

• I also am able to reproduce this after switching screenshots.browser.component.enabled to true.

Comment 1

[Niklas Baumgardner [:niklas]]

We should set the state to selected when we get any mouse event while dragging the overlay.

Comment 2

[Niklas Baumgardner [:niklas]]

Attachment: Bug 1881506 - Handle all button clicks in screenshots overlay. r=sfoster

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/05c33ab06786
Handle all button clicks in screenshots overlay. r=sfoster

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/05c33ab06786

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:niklas, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox125 to wontfix.

For more information, please visit BugBot documentation.

Comment 6

[bhidecuti]

Verified this issue on Firefox Beta 126.0b5, build ID 20240424091756 and on the latest Firefox Nightly 127.0a1, build ID 20240425094116, using macOS 12.6.6, Windows 11 and Ubuntu 22.04 and I am still able to reproduce it on Firefox Beta 126.0b5, while following the steps described in Comment 0.
The issue is no longer reproducible on the mentioned Firefox Nightly build. After releasing the left click button the options to download, copy or close appear and the screenshot area cannot be changed while using the right click or by dragging the mouse.
@niklas, is the fix somehow restricted to nightly builds? Thanks.

Comment 7

[Niklas Baumgardner [:niklas]]

The fix landed in 126 but the screenshots component is not enabled in 126. Have you set screenshots.browser.component.enabled to true in 126?

Comment 8

[bhidecuti]

@niklas, I did not. Thank you for providing this information.
Verified as fixed on Firefox Beta 126.0b6, build ID 20240426091720, using macOS 12.6.6, Windows 11 and Ubuntu 22.04. The issue is no longer reproducible while following the steps described in Comment 0 if the screenshots.browser.component.enabled pref is set to true.