1881508 - Add a yamscripts check to try-runner.js

Status: NEW

(Firefox :: Messaging System, task, P3)

Description

[Shane Hughes [:aminomancer]]

We use Kate Hudson's yamscripts package to deal with JSON's unsuitedness for storing npm scripts. For each of our 3 subprojects (newtab, aboutwelcome, asrouter), npm scripts need to be written in yamscripts.yml, followed by npm run yamscripts. But this is a very easy thing to forget, because everything else is in package.json, leading yamscripts.yml to be pretty obscure.

Since this makes package.json essentially a built file, we should check the before/after in our node(newtab) test (try-runner.js), like we do with other built files. That will prevent the files from getting out of sync, since when you modify scripts in package.json directly, the test will fail, ideally with some useful output telling you that scripts in package.json are generated from yamscripts.yml, so you should copy your modifications into yamscripts.yml.

If we don't want to do this, then I think we should stop using yamscripts. IIRC they've fallen out of sync 3 times just in the last year or so, so it's clearly a common pitfall. Let's fill it in.

Comment 1

[Shane Hughes [:aminomancer]]

Here's how we added a check for aboutwelcome.css.