Closed Bug 1881563 Opened 9 months ago Closed 9 months ago

[wpt-sync] Sync PR 44732 - Replace old CSS2 color parsing tests with JS

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44732 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44732
Details from upstream follow.

Sam Sneddon <gsnedders@apple.com> wrote:

Replace old CSS2 color parsing tests with JS

There are over a thousand near identical tests testing parsing of <color> values across various properties; these cumulatively end up taking several minutes to run which is almost certainly not worthwhile.

Instead, have a single testharness.js test that checks we get the specified value we expect for all the various combinations of property/value.

Note this does keep *-129.xht of each of these to maintain coverage that we do, in fact, render the specified color for each property.

This is practically an alternative to #44728.

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → INVALID
Status: RESOLVED → REOPENED
Resolution: INVALID → ---

CI Results

Ran 7 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1192 subtests

Status Summary

Firefox

OK : 1
PASS: 1192

Chrome

OK : 1
PASS: 1192

Safari

OK : 1
PASS: 1192

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/f422b1af9212 [wpt PR 44732] - Replace old CSS2 color parsing tests with JS, a=testonly https://hg.mozilla.org/integration/autoland/rev/45ceef7e2c92 [wpt PR 44732] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f422b1af9212
https://hg.mozilla.org/mozilla-central/rev/45ceef7e2c92

Status: REOPENED → RESOLVED
Closed: 9 months ago → 9 months ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.