1881607 - Change the Yelp suggestion non-top-pick icon size to 16px

Status: VERIFIED FIXED

(Firefox :: Address Bar, task, P1)

Description

[Drew Willcoxon :adw]

Per the Yelp demo meeting today, the non-top-pick icon size should be 16px. It's currently 24px. The Figma currently shows 24px, and Josh said he'd update it.

Comment 1

[Drew Willcoxon :adw]

Attachment: Bug 1881607 - Change the Yelp suggestion non-top-pick icon size to 16px.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1e4405b4e9db
Change the Yelp suggestion non-top-pick icon size to 16px. r=daisuke

Comment 3

[Cristina Horotan [:chorotan]]

https://hg.mozilla.org/mozilla-central/rev/1e4405b4e9db

Comment 4

[Drew Willcoxon :adw]

Comment on attachment 9382180 [details]
Bug 1881607 - Change the Yelp suggestion non-top-pick icon size to 16px.

Beta/Release Uplift Approval Request

• User impact if declined: This is necessary for the Yelp suggestions experiment that will target 124.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: The non-top-pick Yelp icon should be the same size as other non-top-pick icons in the urlbar panel.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): CSS/styling-only change. Only affects Yelp suggestions, which are disabled by default.
• String changes made/needed:
• Is Android affected?: No

Comment 5

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Nightly 125.0a1 (Build ID: 20240226165659) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 13.1.

• The Yelp suggestion icon from the Firefox Suggest section is now the same size as other non-top-pick icons in the urlbar panel.

Comment 6

[Dianna Smith [:diannaS]]

Comment on attachment 9382180 [details]
Bug 1881607 - Change the Yelp suggestion non-top-pick icon size to 16px.

Approved for 124.0b5

Comment 7

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/e9e0e6686ca7

Comment 8

[Carmen Fat [:cfat] - Ecosystem QA]

I have verified this issue on the latest Firefox Beta 124.0b5 (Build ID: 20240228091714) on Windows 10 x64, Ubuntu 20.04 x64, and macOS 13.1.

• The Yelp suggestion icon from the Firefox Suggest section is now the same size as other non-top-pick icons in the urlbar panel.