1881780 - [wpt-sync] Sync PR 44748 - [line-clamp] Implement the line-clamp CSS property

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44748 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44748
Details from upstream follow.

Andreu Botella <[e-mail]> wrote:

[line-clamp] Implement the line-clamp CSS property

This patch adds the line-clamp property, as well as the
CSSLineClamp Blink feature. It also makes in-flow inline and block
elements after the clamp point hidden for paint in both line-clamp
and -webkit-line-clamp when that feature is enabled, reusing some
existing machinery for table cells.

This patch does not yet handle hiding out of flow boxes, or
height-based clamping. That is left for follow-up CLs.

Since -webkit-line-clamp and line-clamp would usually generate the
same ComputedStyle::LineClamp method, we instead give those methods
the custom names WebkitLineClamp and StandardLineClamp, and reuse
the existing method names LineClamp and HasLineClamp for custom
methods that take both properties into account.

Bug: 40336192
Change-Id: Ic7d0cf6f218b45bd2b7aa5bdd26adaeff9d492db
Reviewed-on: https://chromium-review.googlesource.com/5317993
WPT-Export-Revision: 083ef21e6f29b078e29c1bc8b512e74396de013c

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=39890ca51c94f4e85fd6de94583487f49c46e526

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 8 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 19 tests

Status Summary

Firefox

PASS: 3
FAIL: 16

Chrome

PASS: 3
FAIL: 16

Safari

PASS: 3
FAIL: 16

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /css/css-overflow/line-clamp-001.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-004.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-005.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-006.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-007.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-008.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-009.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-010.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-011.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-012.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-013.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-015.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-016.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-017.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-018.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)
• /css/css-overflow/line-clamp-019.tentative.html [wpt.fyi]: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1a01893fd3c1
[wpt PR 44748] - [line-clamp] Implement the line-clamp CSS property, a=testonly
https://hg.mozilla.org/integration/autoland/rev/362be167a23d
[wpt PR 44748] - Update wpt metadata, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/1a01893fd3c1
https://hg.mozilla.org/mozilla-central/rev/362be167a23d