Closed Bug 1881802 Opened 4 months ago Closed 4 months ago

[Caret browsing] Highlighting doesn't work when pressing shift and arrow down

Categories

(Firefox :: PDF Viewer, defect, P1)

Product:
Firefox
Component:
PDF Viewer
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Tracking Flags:
Tracking Status
firefox-esr115 --- disabled
firefox123 --- disabled
firefox124 --- verified
firefox125 --- verified

People

(Reporter: calixte, Assigned: calixte)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

[mozilla/pdf.js] [Editor] In caret browsing mode, allow to select in pressing shift and arrow down (bug 1881802) (#17720)
44 bytes, text/x-github-pull-request
Details | Review

Attach (recommended) or Link to PDF file here:

Steps to reproduce the problem:

  1. Enable caret browsing mode;
  2. Open a pdf with some text;
  3. Enable highlighting tool;
  4. Position the caret on some text;
  5. Press shift and the arrow down, release shift.

What is the expected behavior? (add screenshot)
The text must be highlighted.

What went wrong? (add screenshot)
Nothing is highlighted.

In caret browsing mode, pdf.js is handling the selection itself, which means that no selectstart is triggered.

Blocks: 1846098
Duplicate of this bug: 1881707
No longer depends on: 1882694
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Depends on: 1883010
No longer depends on: 1883010

Verified as fixed in our latest Nightly build 125.0a1 (2024-03-01) ID 20240301094944.

status-firefox123: --- → disabled
status-firefox124: --- → affected
status-firefox125: --- → verified
status-firefox-esr115: --- → disabled

This issue is Verified as fixed in our latest Beta 124.0b7 because it was uplifted with Bug 1883050.

Status: RESOLVED → VERIFIED
status-firefox124: affected → verified
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: