1881814 - AC Global Preference Update Global Language Action

Status: RESOLVED FIXED

(Firefox for Android :: Translations, task, P1)

Description

[Olivia Hall [:olivia]]

This bug is to add an action for updating the language on the global language settings screen. Need to also ensure the page settings remain in sync.

Comment 1

[Olivia Hall [:olivia]]

Looks like this was added already via bug 1877203! I'm going to improve the documentation around this area. It is easy to miss what APIs are implemented and not implemented. I'll update this bug with better documentation shortly.

Edit: Realize I just saw updateLanguageSetting which is the path for the page settings, not global settings. So, this bug is still valid, but more just adding the action, and less connecting the API.

Comment 2

[Olivia Hall [:olivia]]

Confirming the following Global APIS:

Never Translate This Site:

• Fetch via TranslationsAction.OperationRequestedAction, operation = TranslationOperation.FETCH_NEVER_TRANSLATE_SITES aka requestNeverTranslateSites
  • Sets as TranslationsBrowserState.neverTranslateSites
• Update via TranslationsAction.RemoveNeverTranslateSiteAction aka removeNeverTranslateSite

Language Settings:

• Fetch TranslationsAction.OperationRequestedAction, operation = TranslationOperation.FETCH_AUTOMATIC_LANGUAGE_SETTINGS via aka requestLanguageSettings
  • Sets as TranslationsBrowserState.languageSettings
• Update via NEED TO ADD HERE aka updateLanguageSetting

Comment 3

[Olivia Hall [:olivia]]

Attachment: Bug 1881814 - Translations AC Action to Update Language Preferences

This patch adds the option to update the user's language settings from a global perspective.

• Adds TranslationsAction.UpdateLanguageSettingsAction to update the language setting.
  • TranslationsStateReducer proactively accepts updates and is set on the translations engine
    or else the state is rolled back in TranslationsMiddleware.
• Refactors updateLanguageSetting in TranslationsMiddleware to handle both the page setting and global setting perspective.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1b6148d2775f
Translations AC Action to Update Language Preferences r=android-reviewers,giorga

Comment 5

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/1b6148d2775f