1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18.

Status: RESOLVED FIXED

(Firefox :: Messaging System, defect, P1)

Description

[Mark Banner (:standard8)]

With the latest node 18 on mozilla-central, bundling of asrouter/aboutwelcome code fails due to:

node:internal/crypto/hash:69
  this[kHandle] = new _Hash(algorithm, xofLen);
                  ^

Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:69:19)
    at Object.createHash (node:crypto:133:10)
    at BulkUpdateDecorator.hashFactory (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/util/createHash.js:155:18)
    at BulkUpdateDecorator.update (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/util/createHash.js:46:50)
    at RawSource.updateHash (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack-sources/lib/RawSource.js:77:8)
    at NormalModule._initBuildHash (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/NormalModule.js:888:17)
    at handleParseResult (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/NormalModule.js:954:10)
    at /Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/NormalModule.js:1048:4
    at processResult (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/NormalModule.js:763:11)
    at /Users/mark/dev/gecko/browser/components/asrouter/node_modules/webpack/lib/NormalModule.js:827:5
    at /Users/mark/dev/gecko/browser/components/asrouter/node_modules/loader-runner/lib/LoaderRunner.js:407:3
    at iterateNormalLoaders (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/loader-runner/lib/LoaderRunner.js:233:10)
    at iterateNormalLoaders (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/loader-runner/lib/LoaderRunner.js:240:10)
    at /Users/mark/dev/gecko/browser/components/asrouter/node_modules/loader-runner/lib/LoaderRunner.js:255:3
    at context.callback (/Users/mark/dev/gecko/browser/components/asrouter/node_modules/loader-runner/lib/LoaderRunner.js:124:13)
    at /Users/mark/dev/gecko/browser/components/asrouter/node_modules/babel-loader/lib/index.js:59:71 {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

The webpack version there is v5.56.0 which is quite out of date. newtab is using v5.89.0 which works fine, so lets just update these components.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1881901 - Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r?aminomancer!

An out-of-date webpack was causing the issue, but updating generally is probably a good idea.

Depends on D202621

Comment 2

[BugBot [:suhaib / :marco/ :calixte]]

Set release status flags based on info from the regressing bug 1875239

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/eecdd31ef952
Update asrouter/aboutwelcome to use latest node_modules to fix issues building with node 18. r=aminomancer,omc-reviewers

Comment 4

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/eecdd31ef952