1881927 - Crash in [@ java.lang.NullPointerException: at org.mozilla.geckoview.ContentInputStream.isReadable(ContentInputStream.java)]

Status: RESOLVED FIXED

(GeckoView :: PDF Viewer, defect, P1)

Description

[Chris Peterson [:cpeterson]]

https://crash-stats.mozilla.org/report/index/b2d7eb9b-64f8-4dde-ae90-d1b520240205

This crash looks like a regression in 122.

java.lang.NullPointerException: Attempt to invoke virtual method 'void android.content.res.AssetFileDescriptor.close()' on a null object reference
	at org.mozilla.geckoview.ContentInputStream.isReadable(ContentInputStream.java:37)
	at org.mozilla.gecko.mozglue.GeckoLoader.nativeRun(Native Method)
	at org.mozilla.gecko.GeckoThread.run(GeckoThread.java:611)

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The severity field is not set for this bug.
:owlish, could you have a look please?

For more information, please visit BugBot documentation.

Comment 2

[Olivia Hall [:olivia]]

I think ContentIntputStream is currently only(?) used for reading content URI PDFs to show in the PDF viewer.

Comment 3

[Calixte Denizet (:calixte)]

Attachment: Bug 1881927 - Don't crash when the file descriptor for a content:// uri is null r=#geckoview-reviewers

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4e61c3ac3f94
Don't crash when the file descriptor for a content:// uri is null r=geckoview-reviewers,amejiamarmol

Comment 5

[pstanciu]

https://hg.mozilla.org/mozilla-central/rev/4e61c3ac3f94

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

The patch landed in nightly and beta is affected.
:calixte, is this bug important enough to require an uplift?

• If yes, please nominate the patch for beta approval.
• If no, please set status-firefox124 to wontfix.

For more information, please visit BugBot documentation.

Comment 7

[Calixte Denizet (:calixte)]

Comment on attachment 9390596 [details]
Bug 1881927 - Don't crash when the file descriptor for a content:// uri is null r=#geckoview-reviewers

Beta/Release Uplift Approval Request

• User impact if declined: Some users could have some crash when they try to open a pdf from another app
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Small change which adds a null check
• String changes made/needed:
• Is Android affected?: Yes

Comment 8

[Dianna Smith [:diannaS]]

Comment on attachment 9390596 [details]
Bug 1881927 - Don't crash when the file descriptor for a content:// uri is null r=#geckoview-reviewers

Approved for 124.0.2 dot release

Comment 9

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-release/rev/72375a532ffe