1881941 - Fullscreen video no longer uses the full display area on notched Macbooks

Status: RESOLVED DUPLICATE of bug 1737953

(Core :: Widget: Cocoa, defect, P5)

Description

[Tim]

Attachment: FirefoxFullscreen.pdf

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

Fullscreen a video with the following settings in about:config on a Macbook with a notch:
full-screen-api.macos-native-full-screen, false
full-screen-api.transition-duration.enter, 0 0
full-screen-api.transition-duration.leave, 0 0

Actual results:

The video player no longer utilises the full display area available to show the video and locks the user into a smaller, cropped rectangle where the menubar area is inaccessible and there is a boarder on the left and right sides of the display.

Please see attached pdf (screenshots do not show the issue) as it is hard to describe in words.

Expected results:

The video player utilises the full display and does not lock the user to a smaller, cropped section of the display with the about:config settings mentioned previously applied.

Please see version 122.0.1 photo for the expected result.
I'm not entirely sure if the cropped window is the intended behaviour or not but the previous fullscreen behaviour was perfect but no longer achievable without using the native MacOS fullscreen.

You can still achieve something similar on Ver 123 with full-screen-api.ignore-widgets set to true but that doesn't black out the menubar which is very distracting.

Comment 1

[BugBot [:suhaib / :marco/ :calixte]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Cocoa' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Stephen A Pohl [:spohl]]

I'm not quite sure why this behavior was different on Firefox 122. Could you take a look at bug 1737953 and see if this is the same issue that you reported here?

Comment 3

[Tim]

(In reply to Stephen A Pohl [:spohl] from comment #2)

I'm not quite sure why this behavior was different on Firefox 122. Could you take a look at bug 1737953 and see if this is the same issue that you reported here?

I guess it is the same issue. I've always had 'full-screen-api.transition-duration.enter' and 'full-screen-api.transition-duration.leave' set to '0 0' on all devices so I mustve not noticed the letterboxing issue since I got my MBP 14 in the summer of 2022.
If I reset the two full-screen settings back to the default that FF ships with (200 200) then I get letterboxing on all the versions I have tried (122.0.1, 123, 124.0b5) but with the transition set to '0 0', on FF 122.0.1 the fullscreen video playback uses the correct screen dimensions. Only on FF 123 and higher does the letterboxing appear with the transition set to '0 0'.

I should note, the behaviour when the transition is set to '0 0' is different to when Scale to fit below built-in camera has been deselected. Scale to fit below built-in camera causes text (such as youtube titles) or vertical videos to be clipped by the notch whilst with the transition is set to '0 0', text remains within the safe space and no content exceeds the boundary between apps and the mac menu bar.
Something about the transition being set to '0 0' must be bypassing the letterboxing effect which inadvertently leads to the correct behaviour on 122.0.1 and earlier?

I've reverted back to 122.0.1 and the issue has gone away as you can see from the pictures I uploaded with my original report.

I'm keen to have this fixed as one of the main reasons I switched to FF on macOS was because it didn't use the native full screen mode when viewing videos so happy to try and help as much as I can.

Thanks.