Closed Bug 1881960 Opened 9 months ago Closed 9 months ago

[wpt-sync] Sync PR 44774 - DOM: Add WPTs for removing steps

Categories

(Core :: DOM: Core & HTML, task, P4)

Product:
Core
Component:
DOM: Core & HTML
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44774 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44774
Details from upstream follow.

Dominic Farolino <dom@chromium.org> wrote:

DOM: Add WPTs for removing steps

This CL adds WPTs for removing steps, to ensure that script is never
executed during the removing steps hook 1, which are invoked
synchronously during per-node removal (that is, they are not batched,
but run this way per-node).

This CL:

  1. Augments the existing iframe removing steps WPT, to include
    pagehide events. At the time of writing this, all browsers deviate
    from the HTML Standard, and fail this test.
  2. Adds new tests for \<input> and \<button> to assert that when they
    are focused and subsequently removed from the DOM, the blur event
    is not fired, per the HTML Standard. Chromium fails this test,
    while Safari and Firefox pass it.

Bug: 40150299
Change-Id: I0aa43755ccac8ea432056800c5c4167d8e4460e8

Reviewed-on: https://chromium-review.googlesource.com/5323158
WPT-Export-Revision: 5e6d9f711e3e9028089f04b715eeffdc6844024b

PR 44774 applied with additional changes from upstream: 2a023b35ecade9e3370800b430818c75af1819cb
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 4 subtests

Status Summary

Firefox

OK : 2
PASS : 2
FAIL : 4

Chrome

OK : 2
PASS : 1
FAIL : 5

Safari

OK : 1
PASS : 3
FAIL : 3
ERROR: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /dom/nodes/insertion-removing-steps/insertion-removing-steps-iframe.window.html [wpt.fyi]
    • Insertion steps: load event fires synchronously after iframe DOM insertion, as part of the iframe element's insertion steps: FAIL (Chrome: PASS, Safari: PASS)
    • Removing steps (innerHTML): script does not run synchronously during iframe destruction: FAIL (Chrome: FAIL, Safari: FAIL)
    • Removing steps (replaceChildren): script does not run synchronously during iframe destruction: FAIL (Chrome: FAIL, Safari: FAIL)
    • Removing steps (remove): script does not run synchronously during iframe destruction: FAIL (Chrome: FAIL, Safari: FAIL)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/2b484bc2db06 [wpt PR 44774] - DOM: Add WPTs for removing steps, a=testonly

https://hg.mozilla.org/mozilla-central/rev/2b484bc2db06

Status: NEW → RESOLVED
Closed: 9 months ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.