1881990 - Crash in [@ wgpu_hal::dx12::command::impl$3::end_encoding]

Status: NEW

(Core :: Graphics: WebGPU, defect, P2)

Description

[BugBot [:suhaib / :marco/ :calixte]]

Crash report: https://crash-stats.mozilla.org/report/index/6f5d2fef-4d43-458e-81fd-680890240222

MOZ_CRASH Reason: called `Option::unwrap()` on a `None` value

Top 10 frames of crashing thread:

0  xul.dll  MOZ_Crash  mfbt/Assertions.h:301
0  xul.dll  RustMozCrash  mozglue/static/rust/wrappers.cpp:17
1  xul.dll  mozglue_static::panic_hook  mozglue/static/rust/lib.rs:96
2  xul.dll  core::ops::function::Fn::call<void   /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250
3  xul.dll  alloc::boxed::impl$49::call  library/alloc/src/boxed.rs:2029
3  xul.dll  std::panicking::rust_panic_with_hook  library/std/src/panicking.rs:783
4  xul.dll  std::panicking::begin_panic_handler::closure$0  library/std/src/panicking.rs:649
5  xul.dll  std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0, never$>  library/std/src/sys_common/backtrace.rs:171
6  xul.dll  std::panicking::begin_panic_handler  library/std/src/panicking.rs:645
7  xul.dll  core::panicking::panic_fmt  library/core/src/panicking.rs:72

By querying Nightly crashes reported within the last 2 months, here are some insights about the signature:

• First crash report: 2024-02-11
• Process type: GPU
• Is startup crash: No
• Has user comments: No
• Is null crash: No

By analyzing the backtrace, the regression may have been introduced by a patch [1] to fix Bug 1877985.

[1] https://hg.mozilla.org/mozilla-central/rev?node=85f42e5c2b54

:nical, since you are the author of the potential regressor, could you please take a look?

Comment 1

[Nicolas Silva [:nical]]

Looks unrelated.

Comment 2

[Nicolas Silva [:nical]]

Upstream issue: https://github.com/gfx-rs/wgpu/issues/5285

Comment 3

[Erich Gubler [:ErichDonGubler]]

I know what this is, and it's easy to resolve. Will work on it.

Comment 4

[Erich Gubler [:ErichDonGubler]]

To my embarrassment, I thought I knew what this was, but I actually don't/didn't. See this comment in wgpu#5285; this seems to be a problem when DX12 doesn't support D3D12_FEATURE_DATA_D3D12_OPTIONS13::UnrestrictedBufferTextureCopyPitchSupported.

Will unassign from myself, since this is a P2, and there is an ample number of P1s to work on in WebGPU.