1882043 - Recent searches section is mispositioned in the Address Bar

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Ardelean Oana, Desktop QA [:oardelean]]

Attachment: Screenshot 2024-02-26 at 12.29.45.png

Notes

• Please see the attached screenshot for more details.
• This issue is reproducible only when both Trending search suggestions and Recent Searches are both enabled.

Found in

• Firefox 124.0b3;

Affected versions

• Firefox 124.0b3;

Tested platforms

• Windows 10;
• macOS 12;
• Ubuntu 22;

Affected platforms

• Windows 10;
• macOS 12;
• Ubuntu 22;

Unaffected platforms

• N/A;

Preconditions

• browser.urlbar.suggest.recentsearches = true
• browser.urlbar.suggest.trending =true
• browser.urlbar.trending.featureGate = true
• browser.urlbar.recentsearches.featureGate = true
• browser.urlbar.trending.requireSearchMode = false
• VPN connected to US/CA.
• Google set as default search engine

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Perform a few searches using the default search engine.
3. Go to about:preferences#search and uncheck the ‘Show trending search suggestions’ option.
4. Open a new tab, focus the Address Bar and observe the UI.

Expected result

• Recent searches section is placed below Top Sites.

Actual result

• Recent Searches section is placed above Top Sites.
• 'Shortcuts' string is present.

Regression range

• Will look for one ASAP.

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Bug 1882043 - Ensure recent searches are shown above topsites. r=Mak

Comment 2

[Dale Harvey (:daleharvey)]

Comment on attachment 9382716 [details]
Bug 1882043 - Ensure recent searches are shown above topsites. r=Mak

Beta/Release Uplift Approval Request

• User impact if declined: Would impact planned experiment
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce: QA is currently testing feature
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Minor code change that is tested to feature that is disabled by default
• String changes made/needed:
• Is Android affected?: Yes

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a937207bb6a3
Ensure recent searches are shown above topsites. r=mak

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/a937207bb6a3

Comment 5

[Dianna Smith [:diannaS]]

Comment on attachment 9382716 [details]
Bug 1882043 - Ensure recent searches are shown above topsites. r=Mak

Approved for 124.0b6

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-beta/rev/bbe7094cf33e

Comment 7

[Ardelean Oana, Desktop QA [:oardelean]]

Issue is verified as fixed on Firefox 124.0b6 and Nighty 125.0a1 on Windows 10, macOS 12, Ubuntu 22.
‘Recent Searches’ section is now properly displayed in the address bar.