1882048 - Latest recent search is added with a little delay on the Recent Searches list

Status: RESOLVED WONTFIX

(Firefox :: Address Bar, defect, P3)

Description

[Petruta Horea [:phorea], Desktop Test Engineering]

Notes

• Please see the attached gif for more details.

Found in

• Firefox 124.0b3;

Affected versions

• Firefox 124.0b3; Nightly 125.0a1

Tested platforms

• Windows 11;
• macOS 12;

Affected platforms

• Windows 11;
• macOS 12;

Unaffected platforms

• N/A;

Preconditions

• browser.urlbar.suggest.recentsearches = true
• browser.urlbar.suggest.trending =true
• browser.urlbar.trending.featureGate = true
• browser.urlbar.recentsearches.featureGate = true
• browser.urlbar.trending.requireSearchMode = false
• VPN connected to US/CA.
• Google set as default search engine

Steps to reproduce

1. Launch Firefox with the profile from preconditions.
2. Perform a few searches using the default search engine.
3. Open a new tab after each search and check that the most recent search is added to the Recent Searches list

Expected result

• The latest search item is added instantly to the Recent Searches list

Actual result

• There is a noticeable (short) delay when opening the address bar after new searches were made.

Regression range

• Will look for one ASAP.

Comment 1

[Petruta Horea [:phorea], Desktop Test Engineering]

Attachment: recent.gif

Comment 2

[Dale Harvey (:daleharvey)]

Hey Marco, I was wondering what your opinion on this is, from my understanding of the code there isnt anything we can do quicker, we are pretty much passing Formhistory.search results straight back to the ProvidersManager, I can see that trending have the same flash as the first set is cached then gets repopulated. The FormHistory.search queries arent taking a long time here, usually 1 or 2 ms, I have 14 at the longest which will miss the first batch.

I think this is working as expected, but I would like to hear since you are way more familiar with the urlbar and query performance relating things.

Comment 3

[Marco Bonardo [:mak]]

There may be some space for reducing flicker (that likely consists in further delays), but the roundtrip to disk and back is not easily bypassable without hacks, like some sort of memory cache, that I don't think it's worth the benefit. The use-case of making a search and having an instant need to remake it seems not particularly common. Imo it's a wontfix for the cost/benefit ratio.
Surely it'd be nice to have a smoother rendering of results, but we don't have a clear solution there yet.

Comment 4

[Dale Harvey (:daleharvey)]

Yeh that is what I was thinking cheers, closing as wontfix