1882084 - Support fetchpriority in Early Hints preloader

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement, P3)

Description

[Manuel Bucher [:manuel]]

This will probably only show minor improvements if improvements at all, but we might still want to implement it. See D197493#6954643

Comment 1

[Frédéric Wang (:fredw)]

Attachment: Bug 1882084 - Add WPT tests for fetchpriority in early hints preload. r=valentin

Comment 2

[Frédéric Wang (:fredw)]

I haven't had time to investigate much on this, but just uploaded a patch to remember that there is some WPT tests we could probably rely on https://github.com/web-platform-tests/wpt/issues/8374#issuecomment-2085325404

Comment 3

[Frédéric Wang (:fredw)]

I attached a patch with tests. Good news is that when the headers of early hints is parsed the fetchpriority attribute is already taken into account for adjusting the internal priority of the request (this is what the tests verify). I haven't checked yet if something like D209236 would then be enough to take that internal priority into account for early hints too.

Comment 4

[Frédéric Wang (:fredw)]

(In reply to Frédéric Wang (:fredw) from comment #3)

I haven't checked yet if something like D209236 would then be enough to take that internal priority into account for early hints too.

Talking to valentin, such tests are probably not necessary so I'll land the patch as is.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc3dee64abfb
Add WPT tests for fetchpriority in early hints preload. r=valentin

Comment 6

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/46629 for changes under testing/web-platform/tests

Comment 7

[Serban Stanca [:SerbanS]]

https://hg.mozilla.org/mozilla-central/rev/dc3dee64abfb

Comment 8

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Upstream PR merged by moz-wptsync-bot