Closed Bug 1882120 Opened 2 years ago Closed 2 years ago

[wpt-sync] Sync PR 44789 - [css-scroll-snap-2] Prioritize targets common to both axes

Categories

(Core :: Layout: Scrolling and Overflow, task, P4)

Product:
Core
Component:
Layout: Scrolling and Overflow
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
125 Branch
Tracking Flags:
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 44789 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44789
Details from upstream follow.

David Awogbemila <awogbemila@chromium.org> wrote:

[css-scroll-snap-2] Prioritize targets common to both axes

Per step 6 of the proposal[1] the standardize snap selection points.

Improvements are made to the test files so that scrolling to set(s) of
aligned elements in one or both axes is supported and correctly handled.

Bug: 323840955

[1]https://github.com/w3c/csswg-drafts/issues/9622#issue-2006578282

Change-Id: I8ee234b6d5ae62329fdf12736ebef37ce685dc1b
Reviewed-on: https://chromium-review.googlesource.com/5296594
WPT-Export-Revision: ec4399e0269a4b28da5e5cd8742e209b083ec61d

PR 44789 applied with additional changes from upstream: dce6c697665c98b4cd826257338cc8c2441c133d
Component: web-platform-tests → Layout: Scrolling and Overflow
Product: Testing → Core

CI Results

Ran 6 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 7 tests and 9 subtests

Status Summary

Firefox

OK : 2[Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub] 3[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt]
PASS : 1
FAIL : 16
TIMEOUT: 6
ERROR : 1[Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt] 2[Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub]
NOTRUN : 3

Chrome

OK : 7
PASS : 22
FAIL : 1

Safari

OK : 3
PASS : 1
FAIL : 16
TIMEOUT: 6
ERROR : 1
NOTRUN : 3

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

New Tests That Don't Pass

  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-focused-element.html [wpt.fyi]: SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • scroller selects focused target from aligned choices on snap: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
    • out-of-viewport focused element is not the selected snap target.: NOTRUN (Chrome: PASS, Safari: NOTRUN)
    • scroller follows selected snap target through layout shift,regardless of focus: NOTRUN (Chrome: PASS, Safari: NOTRUN)
  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-focused-nested-containers.html [wpt.fyi]: SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • Snap container prefers focused nested snap target.: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-inner-target.html [wpt.fyi]: SKIP [Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: OK, Safari: TIMEOUT)
    • snap container selects innermost area as snap target: TIMEOUT (Chrome: PASS, Safari: TIMEOUT)
    • snap container follows selected snap target after layout change (the pre-existing snap target should not be overriden because of the innermost area): NOTRUN (Chrome: PASS, Safari: NOTRUN)
  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/nested-supercedes-common-to-both-axes.html [wpt.fyi]
    • scroller prefers nested area over area aligned in both axes.: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-common-to-both-axes.html [wpt.fyi]
    • scroller prefers target aligned in both axes.: FAIL (Chrome: FAIL, Safari: FAIL)
  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-targeted-element-positioned.html [wpt.fyi]: ERROR [Gecko-linux1804-64-qr-debug, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt, GitHub], OK [Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-opt] (Chrome: OK, Safari: OK)
    • prefer-targeted-element-positioned: FAIL (Chrome: PASS, Safari: FAIL)
    • prefer-targeted-element-positioned 1: FAIL (Chrome: PASS, Safari: FAIL)
    • prefer-targeted-element-positioned 2: FAIL (Chrome: PASS, Safari: FAIL)
    • prefer-targeted-element-positioned 3: FAIL (Chrome: PASS, Safari: FAIL)
    • prefer-targeted-element-positioned 4: FAIL (Chrome: PASS, Safari: FAIL)
  • /css/css-scroll-snap/snap-after-relayout/multiple-aligned-targets/prefer-targeted-element.html [wpt.fyi]: ERROR (Chrome: OK, Safari: ERROR)
    • scroller selects targeted area box1 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box2 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box3 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box4 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box5 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box6 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box7 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box8 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)
    • scroller selects targeted area box9 among multiple aligned areas.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/9409a259e1ce [wpt PR 44789] - [css-scroll-snap-2] Prioritize targets common to both axes, a=testonly https://hg.mozilla.org/integration/autoland/rev/00ba37520d83 [wpt PR 44789] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/9409a259e1ce
https://hg.mozilla.org/mozilla-central/rev/00ba37520d83

Status: NEW → RESOLVED
Closed: 2 years ago
status-firefox125: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.