Closed Bug 1882208 Opened 9 months ago Closed 9 months ago

[wpt-sync] Sync PR 44803 - [Protected Audiences] Improve WPT request waiting functions.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox125 fixed)

RESOLVED FIXED
125 Branch
Tracking Status
firefox125 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(7 files)

Sync web-platform-tests PR 44803 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44803
Details from upstream follow.

Matt Menke <mmenke@chromium.org> wrote:

[Protected Audiences] Improve WPT request waiting functions.

In particular:

  • Don't hang if too many requests are received, but all match expected
    requests.
  • sort() after applying string substitutions to request array, so even
    if strings are passed in post-substitution, sorting is consistent.
  • Add an optional filter parameter, and make
    waitForObservedRequestsIgnoreDebugOnlyReports() call
    waitForObservedRequests() with a filter. This reduces redundancy,
    and should hopefully prevent the former function from becoming
    outdated as the latter is improved/has bugs fixed (which was
    previously the case).

Bug: None
Change-Id: I9c91f8ab0e7f66eec4e7315f158f92a4c4609712
Reviewed-on: https://chromium-review.googlesource.com/5324506
WPT-Export-Revision: 78ce5a2f106f730f2cc781c805b68f42f49b6c14

Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Attached file Notable wpt changes
# CI Results Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 130 tests and 4 subtests ## Status Summary ### Firefox `OK` : 124[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 128[GitHub] `FAIL` : 604[Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt] 616[GitHub] `ERROR` : 1 `NOTRUN`: 1 ### Chrome `OK` : 129 `PASS` : 207 `FAIL` : 410 ### Safari `OK` : 128 `FAIL` : 616 `ERROR` : 1 `NOTRUN`: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=51469da9987975fc1e0d9f50d889b0e2e7a1da6b) [GitHub PR Head](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=24903838bd7ce477bf7569c813dfc73503b80d4e&label=pr_base) ## Details (See attachment for full changes)
Test result changes from PR not available.
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/655d59c8814f [wpt PR 44803] - [Protected Audiences] Improve WPT request waiting functions., a=testonly
Status: NEW → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: