1882291 - build failure in gfx/qcms/src/lib.rs with Nightly rust

Status: RESOLVED FIXED

(Core :: Graphics: Color Management, defect)

Description

[Jonathan Kew [:jfkthame]]

With rustup default nightly, I'm currently seeing a build failure:

 2:15.15 error[E0635]: unknown feature `stdsimd`
 2:15.15   --> gfx/qcms/src/lib.rs:10:39
 2:15.15    |
 2:15.15 10 | #![cfg_attr(feature = "neon", feature(stdsimd))]

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Attachment: Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=1.78.

We only need this on ARM32 because the ARM64 intrinsics are stable.

stdarch_arm_neon_intrinsics was split out from stdsimd here:
https://github.com/rust-lang/stdarch/pull/1486

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e9b01ce8e2fe
Switch to stdarch_arm_neon_intrinsics feature on rust >=1.78. r=glandium

Comment 3

[Norisz Fay [:noriszfay]]

https://hg.mozilla.org/mozilla-central/rev/e9b01ce8e2fe

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 9388216 [details]
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=1.78.

ESR Uplift Approval Request

• If this is not a sec:{high,crit} bug, please state case for ESR consideration: This fixes the build on newer versions of Rust.
• User impact if declined: New versions of rust won't be able to build Firefox
• Fix Landed on Version: 125
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): It's just a build fix.

Comment 5

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

Comment on attachment 9388216 [details]
Bug 1882291. Switch to stdarch_arm_neon_intrinsics feature on rust >=1.78.

Approved for 115.12esr.

Comment 6

[Pulsebot]

https://hg.mozilla.org/releases/mozilla-esr115/rev/792a5db48bd3