1882390 - [wpt-sync] Sync PR 44814 - Reland "[FedCM] Allow button flow to replace widget flow"

Status: RESOLVED FIXED

(Core :: DOM: Credential Management, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44814 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44814
Details from upstream follow.

Yi Gu <[e-mail]> wrote:

Reland "[FedCM] Allow button flow to replace widget flow"

This reverts commit b57a0adddbd8aaa68fb06cd5cfd24a33296728ea.

Reason for revert: Fixed test in patchset 2

Original change's description:

Revert "[FedCM] Allow button flow to replace widget flow"

This reverts commit a2783105732c27a57dd0c3e1100730cc4aec32e0.

Reason for revert: Suspected of causing failures on WebKit Linux Leak: https://ci.chromium.org/ui/p/chromium/builders/ci/WebKit%20Linux%20Leak/60801/overview (and other runs since)

Original change's description:

[FedCM] Allow button flow to replace widget flow

Since button flow implies stronger user login intention of, it should
take precedence over the widget flow. In particular:

1. If there's an in-flight button request, reject any coming widget request
2. If there's an in-flight widget request, replace it with the button request

This patch also fixes an issue where we persisted the rp_mode_ after a
button flow.

Bug: 41483050
Change-Id: Ic75ba4ab359a9247f4c41b75ad84f7a3cabeb0c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5321982
Commit-Queue: Yi Gu \<[e-mail]>
Reviewed-by: Christian Biesinger \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1265238}

Bug: 41483050
Change-Id: I82728a8ea02194f46eed086015473975a4017dc4
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5317868
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Stephen McGruer \<[e-mail]>
Reviewed-by: Yi Gu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1265306}

Bug: 41483050
Change-Id: I600b03200b95e4f5112f2a1ae45a4c8675ce7b28
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5327886
Reviewed-by: Christian Biesinger \<[e-mail]>
Commit-Queue: Yi Gu \<[e-mail]>
Cr-Commit-Position: refs/heads/main@{#1265980}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ca2bf9f354ca5836d1eb15d593da83d56222d24d

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 6 subtests

Status Summary

Firefox

TIMEOUT: 2
NOTRUN : 5

Chrome

TIMEOUT: 2
NOTRUN : 5

Safari

FAIL : 6
ERROR : 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /credential-management/fedcm-button-mode-basics.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)
  • Test that the button mode without user activation will fail.: TIMEOUT (Chrome: TIMEOUT, Safari: FAIL)
  • Test that the button mode requires user activation.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the button mode can replace widget mode.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the widget mode can succeed after the button mode.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the button mode cannot replace button mode.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)
  • Test that the widget mode cannot replace button mode.: NOTRUN (Chrome: NOTRUN, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

• /credential-management/fedcm-button-mode-basics.https.html [wpt.fyi]: SKIP [Gecko-android-em-7.0-x86_64-lite-qr-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-windows11-32-2009-qr-debug, Gecko-windows11-32-2009-qr-opt, Gecko-windows11-64-2009-qr-debug, Gecko-windows11-64-2009-qr-opt], TIMEOUT [GitHub] (Chrome: TIMEOUT, Safari: ERROR)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/88c0c022a985
[wpt PR 44814] - Reland "[FedCM] Allow button flow to replace widget flow", a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/88c0c022a985