Closed
Bug 1882405
Opened 1 year ago
Closed 1 year ago
Fix Bug in Translations Reducer that prevents Updates being Emitted to Observers
Categories
(Firefox for Android :: Translations, defect, P1)
Tracking
()
RESOLVED
FIXED
125 Branch
| Tracking | Status | |
|---|---|---|
| firefox123 | --- | unaffected |
| firefox124 | --- | wontfix |
| firefox125 | --- | fixed |
People
(Reporter: olivia, Assigned: olivia)
References
(Regression)
Details
(Keywords: regression, Whiteboard: [fxdroid][foundation])
Attachments
(1 file)
When testing this patch, toggles weren't being updated based on the value, even though the browser store knew the correct value. This is due to using var for this PageSettings data structure to set items like this in the reducer. Switching back from var to val on the data structure and making a new pageSettings each time fixed the issue.
|
Assignee | |
Updated•1 year ago
|
Assignee: nobody → ohall
Severity: -- → S3
Depends on: fx-translation-android
Keywords: regression
Priority: -- → P1
Regressed by: 1877203
Whiteboard: [fxdroid][foundation]
|
||
Updated•1 year ago
|
|
||
Comment 1•1 year ago
|
||
Set release status flags based on info from the regressing bug 1877203
status-firefox123:
--- → unaffected
status-firefox124:
--- → affected
status-firefox125:
--- → affected
|
||
Comment 2•1 year ago
|
||
|
|
Assignee | |
Updated•1 year ago
|
|
|
Assignee | |
Updated•1 year ago
|
Blocks: 1856986, fx-translation-android
No longer depends on: fx-translation-android
|
|
||
Comment 3•1 year ago
|
||
Authored by https://github.com/ohall-m
https://github.com/mozilla-mobile/firefox-android/commit/86413931058ab4b9846abd7f9345792f6da51b5a
[main] Bug 1882405 - Page Settings Data Structure Should be Val
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → 125 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•