1882416 - Crash in [@ euclid::size::Size2D<T>::cast] on assertion failed: !size.is_empty()

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, defect)

Description

[Andrew McCreight [:mccr8]]

Crash report: https://crash-stats.mozilla.org/report/index/7c39d8fd-0a53-4ad9-851e-445990240227

MOZ_CRASH Reason: assertion failed: !size.is_empty()

Top 10 frames of crashing thread:

0  xul.dll  MOZ_Crash  mfbt/Assertions.h:301
0  xul.dll  RustMozCrash  mozglue/static/rust/wrappers.cpp:17
1  xul.dll  mozglue_static::panic_hook  mozglue/static/rust/lib.rs:96
2  xul.dll  core::ops::function::Fn::call<void   /rustc/07dca489ac2d933c78d3c5158e3f43beefeb02ce/library/core/src/ops/function.rs:250
3  xul.dll  alloc::boxed::impl$49::call  library/alloc/src/boxed.rs:2029
3  xul.dll  std::panicking::rust_panic_with_hook  library/std/src/panicking.rs:783
4  xul.dll  std::panicking::begin_panic_handler::closure$0  library/std/src/panicking.rs:649
5  xul.dll  std::sys_common::backtrace::__rust_end_short_backtrace<std::panicking::begin_panic_handler::closure_env$0, never$>  library/std/src/sys_common/backtrace.rs:171
6  xul.dll  std::panicking::begin_panic_handler  library/std/src/panicking.rs:645
7  xul.dll  core::panicking::panic_fmt  library/core/src/panicking.rs:72

Comment 1

[Andrew McCreight [:mccr8]]

[Tracking Requested - why for this release]: big crash regression

This looks like a huge crash spike on the 20240227095754 Nightly build. Here is the set of changes in that Nightly.

Comment 2

[Andrew McCreight [:mccr8]]

Bug 1882044 added a new assert!(!size.is_empty()); and it is in the regression range. I can't tell if that's the one the crash is hitting, though. nical, does that make sense? Maybe this is a signature change from some other crash? Thanks.

Comment 3

[Andrew McCreight [:mccr8]]

Ah, it looks like there are at least 3 new signatures with this assertion.

Comment 4

[Andrew McCreight [:mccr8]]

FWIW I don't see any more signatures besides these 3 with this assertion. (aside from a single instance of an empty minidump)

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug is linked to a topcrash signature, which matches the following criterion:

• Top 10 desktop browser crashes on nightly

For more information, please visit BugBot documentation.

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Fixed by backout.

Comment 9

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.

Comment 10

[BugBot [:suhaib / :marco/ :calixte]]

Copying crash signatures from duplicate bugs.