1882445 - [wpt-sync] Sync PR 44824 - Add WPTs for auctionReportBuyersDebugModeConfig, fix crash identified

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 44824 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/44824
Details from upstream follow.

Alex Turner <[e-mail]> wrote:

Add WPTs for auctionReportBuyersDebugModeConfig, fix crash identified

Adds Web Platform Tests for the feature that allows debug mode to be
specified for auctionReportBuyers reporting.

Also fixes a crash identified by these tests. When an
auctionReportBuyersDebugModeConfig is provided and enabled is false, but
a debugKey is still provided, a TypeError is correctly thrown. The
auction should also fail at that point, but before this change that did
not occur. Instead, a CHECK was later hit.

Bug: 41485586, 327247098
Change-Id: Ia843011ff1dd74a5e4ba48002f5bea1b77d074d0
Reviewed-on: https://chromium-review.googlesource.com/5328953
WPT-Export-Revision: 0e9028a63f0ea6ac713a2054bf87e2211ac4ece5

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc33b0f52b83c28d0928dc74daf1ae327208ee22

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 9 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 9 subtests

Status Summary

Firefox

OK : 1
PASS: 4
FAIL: 5

Chrome

OK : 1
PASS: 4
FAIL: 5

Safari

OK : 1
PASS: 4
FAIL: 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

• /private-aggregation/protected-audience-auction-report-buyers-debug-mode-surface.https.html [wpt.fyi]
  • auctionReportBuyerDebugModeConfig missing: FAIL (Chrome: FAIL, Safari: FAIL)
  • auctionReportBuyerDebugModeConfig with enabled true: FAIL (Chrome: FAIL, Safari: FAIL)
  • auctionReportBuyerDebugModeConfig with enabled true and debug key: FAIL (Chrome: FAIL, Safari: FAIL)
  • auctionReportBuyerDebugModeConfig with enabled false: FAIL (Chrome: FAIL, Safari: FAIL)
  • auctionReportBuyerDebugModeConfig empty: FAIL (Chrome: FAIL, Safari: FAIL)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7975a43123c0
[wpt PR 44824] - Add WPTs for auctionReportBuyersDebugModeConfig, fix crash identified, a=testonly
https://hg.mozilla.org/integration/autoland/rev/b6c4ebc73fe2
[wpt PR 44824] - Update wpt metadata, a=testonly

Comment 4

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/7975a43123c0
https://hg.mozilla.org/mozilla-central/rev/b6c4ebc73fe2