1882449 - wayland-session.log spammed with "WaylandMessage::Write()" error messages

Status: RESOLVED FIXED

(Core :: Widget: Gtk, defect, P2)

Description

[Harishankar Gaddanakeri [:voiceroy]]

Attachment: wayland-session.log

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0

Steps to reproduce:

1. Lauch Firefox
2. CPU usage rises to 80-90%
3. The ~/.local/share/sddm/wayland-session.log grows in size very fastly, consuming large amounts of disk space.
4. The log file is spammed with the message "Error: WaylandMessage::Write() too many files to send
   : "

Actual results:

This only happens whenever I start firefox on sway (wayland), regardless of whether I reload swaywm using mod+shift+c. CPU usage stays at 80-90% and the log file starts to consume disk space. At the time I noticed it, the log file was ~140GB with all of the lines being "Error: WaylandMessage::Write() too many files to send
: "

Expected results:

CPU usage should be normal.
Log files shouldn't consume large amount of space in a very short period of time.

Comment 1

[BugBot [:suhaib / :marco]]

The Bugbug bot thinks this bug should belong to the 'Core::Widget: Gtk' component, and is moving the bug to that component. Please correct in case you think the bot is wrong.

Comment 2

[Nigel Babu [:nigelb]]

I've seen this happen to my /var/log/syslog file. There are some upstream bugs in several distros: https://bugs.launchpad.net/ubuntu/+source/firefox/+bug/2051838

Comment 3

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

That's interesting, Thanks. Do you see that on Sway only? Can you test Mutter for instance?
https://fedoraproject.org/wiki/How_to_debug_Firefox_problems#Testing_different_Wayland_compositor

It looks like Sway sends too many files over IPC so we can't handle it.
As a workaround you can run Firefox with MOZ_DISABLE_WAYLAND_PROXY=1 env variable set.

Comment 4

[Harishankar Gaddanakeri [:voiceroy]]

Can you mind looking at this issue: https://github.com/swaywm/sway/issues/8006

Comment 5

[Harishankar Gaddanakeri [:voiceroy]]

Attachment: wayland-session.log

Comment 6

[Harishankar Gaddanakeri [:voiceroy]]

By running firefox in mutter, I get these logs

01:09:40.053 [ERROR] [wlr] [types/xdg_shell/wlr_xdg_surface.c:169] A configure is scheduled for an uninitialized xdg_surface 0x5f107dcb2440
01:09:41.877 [ERROR] [wlr] [types/xdg_shell/wlr_xdg_surface.c:169] A configure is scheduled for an uninitialized xdg_surface 0x5f107d4f9230

With lots of space and newline characters in the file.
I've attached the file

Comment 7

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

It's because we write max MAX_LIBWAY_FDS-1 fds.

Comment 8

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

Attachment: Bug 1882449 [Wayland Proxy] Use ErrorPlain() to print all errors without errno r?emilio

• Make Error()/Warning() always print errno
• Use ErrorPlain() to print all warnings without errno

Comment 9

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

Attachment: Bug 1882449 [Wayland Proxy] Allow to read/write up to MAX_LIBWAY_FDS fds num r?emilio

Depends on D203107

Comment 10

[Martin Stránský [:stransky] (ni? me) (PTO till Aug 03)]

Attachment: Bug 1882449 [Wayland Proxy] Remove redundant mLoaded flag r?emilio

Depends on D203108

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aef095e096ff
[Wayland Proxy] Use ErrorPlain() to print all errors without errno r=emilio
https://hg.mozilla.org/integration/autoland/rev/7d0c24d09691
[Wayland Proxy] Allow to read/write up to MAX_LIBWAY_FDS fds num r=emilio
https://hg.mozilla.org/integration/autoland/rev/44c183650174
[Wayland Proxy] Remove redundant mLoaded flag r=emilio

Comment 12

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/aef095e096ff
https://hg.mozilla.org/mozilla-central/rev/7d0c24d09691
https://hg.mozilla.org/mozilla-central/rev/44c183650174