188251 - shrink embedding resource footprint

Status: RESOLVED FIXED

(Core Graveyard :: Embedding: GRE Core, defect)

Description

[Alec Flett]

I found a few minor tweaks we can make to shrink our embedding/GRE footprint, by
tweaking and/or removing some resources.

1) transliterate.properties contains a ton of comments - 47k of them in fact. By
stripping the comments I saved 47k of disk footprint.
2) we can dump a bunch of math .properties and .css files by specifying
individual font and entityTables in basebrowser-*-supp. By dropping MathML
support entirely, we drop at least 192k in resource files
3) necko2.dll is no longer necessary as of this moment - I moved the FTP stuff
into the main necko DLL - I think the savings will be around 44k. 

Patch forthcoming.

Comment 1

[Alec Flett]

Attachment: clean up resource inclusion on windows

This cleans up transliterate.properties by removing all the unnecessary
comments, and cleans up basebrowser-win and basebrowser-win-supp to make mathML
not part of the default embedding configuration, as well as removing necko2.dll

Comment 2

[Alec Flett]

Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

Doug/Darin can I get reviews? its most just manifest cleanups and comment
removal

Comment 3

[Boris Zbarsky [:bzbarsky]]

wouldn't it be better to handle comment removal at build time via a script? 
Unless that file is auto-generated, that change will make it kinda hard to work
with...

Comment 4

[Alec Flett]

the file is in fact autogenerated but was only generated once. I'm not sure
anyone has every looked at the comments though, they're just overkill. I'll
update the script too...

Comment 5

[Boris Zbarsky [:bzbarsky]]

ok, thanks.  ;)

Comment 6

[Alec Flett]

Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

Dougt is on vacation, looking for other reviews...I'd really really like to get
this in today.. can anyone help me out? bz?

I'll attach the patch to the gentransliterate.pl file as well.

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

> +; components\necko_ftp.xpt

Why is this no longer needed?

Other than that, looks fine

Comment 8

[Alec Flett]

Attachment: update the script as well

here's the script that generates the files - I just commented out the line in
case someone ever wants to debug this stuff.

Comment 9

[Alec Flett]

Comment on attachment 111079 [details] [diff] [review]
update the script as well

And here's the script.. guess I ought to get a review on that too :)

Comment 10

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 111079 [details] [diff] [review]
update the script as well

r/sr=bzbarsky.	Perfect.

Comment 11

[Alec Flett]

oops, that necko_ftp comment-out is a typo.

Comment 12

[Darin Fisher]

Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

>Index: embedding/config/basebrowser-win

>+; optional for gopher/viewsource/etc support
>+; components\necko2.dll
>+; components\necko_ftp.xpt

is "necko_ftp.xpt" still needed?  what about necko_viewsource.xpt?

otherwise sr=darin

Comment 13

[Darin Fisher]

Comment on attachment 111079 [details] [diff] [review]
update the script as well

sr=darin

Comment 14

[Alec Flett]

Attachment: cleanup mac/unix as well

This cleans up the mac/unix embedding manifests in the same manner - in
addition you'll notice that I'm removing references to gkcontent as per fallout
from bug 106161

Comment 15

[Alec Flett]

Comment on attachment 111522 [details] [diff] [review]
cleanup mac/unix as well

doug/bryner - do you mind reviewing? Easy stuff - bryner I asked you because
this includes the layout/content merge...

Comment 16

[Doug Turner (:dougt)]

Comment on attachment 111522 [details] [diff] [review]
cleanup mac/unix as well

sure.

Comment 17

[Alec Flett]

ok, all fixed. thanks folks.