shrink embedding resource footprint

RESOLVED FIXED in mozilla1.3beta

Status

Core Graveyard
Embedding: GRE Core
RESOLVED FIXED
15 years ago
a year ago

People

(Reporter: Alec Flett, Assigned: Alec Flett)

Tracking

Trunk
mozilla1.3beta
x86
Windows 2000

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: still need to do mac/unix)

Attachments

(3 attachments)

(Assignee)

Description

15 years ago
I found a few minor tweaks we can make to shrink our embedding/GRE footprint, by
tweaking and/or removing some resources.

1) transliterate.properties contains a ton of comments - 47k of them in fact. By
stripping the comments I saved 47k of disk footprint.
2) we can dump a bunch of math .properties and .css files by specifying
individual font and entityTables in basebrowser-*-supp. By dropping MathML
support entirely, we drop at least 192k in resource files
3) necko2.dll is no longer necessary as of this moment - I moved the FTP stuff
into the main necko DLL - I think the savings will be around 44k. 

Patch forthcoming.
(Assignee)

Comment 1

15 years ago
Created attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

This cleans up transliterate.properties by removing all the unnecessary
comments, and cleans up basebrowser-win and basebrowser-win-supp to make mathML
not part of the default embedding configuration, as well as removing necko2.dll
(Assignee)

Comment 2

15 years ago
Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

Doug/Darin can I get reviews? its most just manifest cleanups and comment
removal
Attachment #110990 - Flags: superreview?(darin)
Attachment #110990 - Flags: review?(dougt)
wouldn't it be better to handle comment removal at build time via a script? 
Unless that file is auto-generated, that change will make it kinda hard to work
with...
(Assignee)

Comment 4

15 years ago
the file is in fact autogenerated but was only generated once. I'm not sure
anyone has every looked at the comments though, they're just overkill. I'll
update the script too...
ok, thanks.  ;)
(Assignee)

Comment 6

15 years ago
Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

Dougt is on vacation, looking for other reviews...I'd really really like to get
this in today.. can anyone help me out? bz?

I'll attach the patch to the gentransliterate.pl file as well.
Attachment #110990 - Flags: review?(dougt) → review?(bzbarsky)
Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

> +; components\necko_ftp.xpt

Why is this no longer needed?

Other than that, looks fine
Attachment #110990 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 8

15 years ago
Created attachment 111079 [details] [diff] [review]
update the script as well

here's the script that generates the files - I just commented out the line in
case someone ever wants to debug this stuff.
(Assignee)

Comment 9

15 years ago
Comment on attachment 111079 [details] [diff] [review]
update the script as well

And here's the script.. guess I ought to get a review on that too :)
Attachment #111079 - Flags: superreview?(darin)
Attachment #111079 - Flags: review?(bzbarsky)
Comment on attachment 111079 [details] [diff] [review]
update the script as well

r/sr=bzbarsky.	Perfect.
Attachment #111079 - Flags: review+
(Assignee)

Comment 11

15 years ago
oops, that necko_ftp comment-out is a typo.

Comment 12

15 years ago
Comment on attachment 110990 [details] [diff] [review]
clean up resource inclusion on windows

>Index: embedding/config/basebrowser-win

>+; optional for gopher/viewsource/etc support
>+; components\necko2.dll
>+; components\necko_ftp.xpt

is "necko_ftp.xpt" still needed?  what about necko_viewsource.xpt?

otherwise sr=darin
Attachment #110990 - Flags: superreview?(darin) → superreview+

Comment 13

15 years ago
Comment on attachment 111079 [details] [diff] [review]
update the script as well

sr=darin
Attachment #111079 - Flags: superreview?(darin) → superreview+
(Assignee)

Updated

15 years ago
Status: NEW → ASSIGNED
Whiteboard: still need to do mac/unix
Target Milestone: --- → mozilla1.3beta
Attachment #111079 - Flags: review?(bzbarsky)
(Assignee)

Comment 14

15 years ago
Created attachment 111522 [details] [diff] [review]
cleanup mac/unix as well

This cleans up the mac/unix embedding manifests in the same manner - in
addition you'll notice that I'm removing references to gkcontent as per fallout
from bug 106161
(Assignee)

Comment 15

15 years ago
Comment on attachment 111522 [details] [diff] [review]
cleanup mac/unix as well

doug/bryner - do you mind reviewing? Easy stuff - bryner I asked you because
this includes the layout/content merge...
Attachment #111522 - Flags: superreview?(bryner)
Attachment #111522 - Flags: review?(dougt)
Attachment #111522 - Flags: superreview?(bryner) → superreview+

Comment 16

15 years ago
Comment on attachment 111522 [details] [diff] [review]
cleanup mac/unix as well

sure.
Attachment #111522 - Flags: review?(dougt) → review+
(Assignee)

Comment 17

15 years ago
ok, all fixed. thanks folks.
Status: ASSIGNED → RESOLVED
Last Resolved: 15 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.