1882575 - `moz-phab submit` hanging due to the spinner

Status: RESOLVED FIXED

(Conduit :: moz-phab, defect)

Description

[Connor Sheehan [:sheehan]]

A few users have reported issues with hangs in moz-phab recently that seem to go away once DEBUG=1 is passed in the environment. At first we assumed this issue was due to a luck-of-the-draw situation. After looking at the internals controlled by the DEBUG flag we realized the flag enables lower level logging in the terminal, but also disables the "spinner" which indicates to the user that a long-running operation is still active. :afranchuk hacked their moz-phab to disable the spinner without DEBUG immediately after hitting a hang condition in moz-phab submit and the command completed successfully. So it appears there is an issue with the spinner that causes it to hang instead of returning control flow back to the main submit function.

Both users were on moz-phab 1.5.1, Linux, Python 3.11/3.12.

Comment 1

[Connor Sheehan [:sheehan]]

Attachment: spinner: add an environment variable to enable/disable the spinner (Bug 1882575) r?glob,zeid

moz-phab's spinner implementation has a bug which can cause hangs.
While we track down the bug, it would be convenient to add an escape
hatch to disable the spinner, similar to other similar variables. Add
a SHOW_SPINNER environment variable that can be used to hide the
spinner.

Comment 2

[Paul Adenot (:padenot)]

This has landed, I'm closing it.