Closed
Bug 1882581
Opened 6 months ago
Closed 6 months ago
Implement Parsing for @scope
Categories
(Core :: CSS Parsing and Computation, enhancement)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
126 Branch
Tracking | Status | |
---|---|---|
firefox126 | --- | fixed |
People
(Reporter: dshin, Assigned: dshin)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
No description provided.
Assignee | ||
Updated•6 months ago
|
Severity: -- → S3
Assignee | ||
Comment 1•6 months ago
|
||
Updated•6 months ago
|
Assignee: nobody → dshin
Status: NEW → ASSIGNED
Pushed by dshin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/4781bbc7324f Implement `@scope` parsing. r=firefox-style-system-reviewers,saschanaz,emilio https://hg.mozilla.org/integration/autoland/rev/9f390afd0df5 Allow parsing `scope-end` selector as relative, anchoring at `:scope`. r=firefox-style-system-reviewers,emilio
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/45186 for changes under testing/web-platform/tests
Comment 5•6 months ago
|
||
Backed out for causing bustage on InspectorUtils.cpp
- backout: https://hg.mozilla.org/integration/autoland/rev/84c9d7f24e50a1103fd04d35a872b044a4063e35
- push: https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=9f390afd0df5166e4e3b28fd35039ccb9f63017d
- failure log: https://treeherder.mozilla.org/logviewer?job_id=451217647&repo=autoland&lineNumber=28895
[task 2024-03-19T02:55:54.627Z] 02:55:54 INFO - In file included from Unified_cpp_layout_inspector0.cpp:11:
[task 2024-03-19T02:55:54.629Z] 02:55:54 ERROR - /builds/worker/checkouts/gecko/layout/inspector/InspectorUtils.cpp:414:19: error: enumeration value 'Scope' not handled in switch [-Werror,-Wswitch]
[task 2024-03-19T02:55:54.630Z] 02:55:54 INFO - 414 | switch (rule->Type()) {
[task 2024-03-19T02:55:54.630Z] 02:55:54 INFO - | ~~~~~~^~~~~~
[task 2024-03-19T02:55:54.630Z] 02:55:54 INFO - 1 error generated.
[task 2024-03-19T02:55:54.630Z] 02:55:54 ERROR - gmake[4]: *** [/builds/worker/checkouts/gecko/config/rules.mk:690: Unified_cpp_layout_inspector0.o] Error 1
[task 2024-03-19T02:55:54.631Z] 02:55:54 INFO - gmake[4]: Leaving directory '/builds/worker/workspace/obj-build/layout/inspector'
[task 2024-03-19T02:55:54.632Z] 02:55:54 INFO - gmake[4]: Target 'target-objects' not remade because of errors.
[task 2024-03-19T02:55:54.632Z] 02:55:54 ERROR - gmake[3]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:72: layout/inspector/target-objects] Error 2
Flags: needinfo?(dshin)
Upstream PR was closed without merging
Pushed by dshin@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3084919478fa Implement `@scope` parsing. r=firefox-style-system-reviewers,saschanaz,emilio https://hg.mozilla.org/integration/autoland/rev/86b02f822790 Allow parsing `scope-end` selector as relative, anchoring at `:scope`. r=firefox-style-system-reviewers,emilio
Assignee | ||
Updated•6 months ago
|
Flags: needinfo?(dshin)
Comment 8•6 months ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3084919478fa
https://hg.mozilla.org/mozilla-central/rev/86b02f822790
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
status-firefox126:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 126 Branch
Upstream PR merged by moz-wptsync-bot
Comment 10•6 months ago
|
||
:dshin could you consider nominating this for a release note? (Process info)
We could include it in the nightly release notes.
Flags: needinfo?(dshin)
Assignee | ||
Comment 11•6 months ago
|
||
:dmeehan - I think it's better to do so after bug 1886441 where some form of functionality is available behind pref, rather than just treating it as a no-op.
Flags: needinfo?(dshin)
You need to log in
before you can comment on or make changes to this bug.
Description
•